-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TikzPictures.jl requirement #110
Merged
d-monnet
merged 11 commits into
JuliaSmoothOptimizers:main
from
d-monnet:tikz-dep-require
Nov 22, 2023
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
840b779
Makes TikzPictures.jl a requirement for using export_performance_prof…
d-monnet 1501767
fix TikzPictures load
d-monnet 8f39961
update Project.toml
d-monnet 24f1abb
Apply suggestions from code review
tmigot c089cb2
add Project.toml to test folder
d-monnet 287d418
Merge branch 'tikz-dep-require' of https://github.com/d-monnet/Benchm…
d-monnet 62ffedb
white background for legend box
d-monnet bdebff1
remove using
tmigot 43154c0
Add ref to package TikzPictures
tmigot cc85b0b
add deps in tests' Project.toml
d-monnet f99bd6a
Merge branch 'tikz-dep-require' of https://github.com/d-monnet/Benchm…
d-monnet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
[deps] | ||
LaTeXStrings = "b964fa9f-0449-5b57-a5c2-d3ea65f4040f" | ||
PGFPlotsX = "8314cec4-20b6-5062-9cdb-752b83310925" | ||
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80" | ||
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
TikzPictures = "37f6aa50-8035-52d0-81c2-5a1d08754b2d" | ||
UnicodePlots = "b8865327-cd53-5732-bb35-84acbb429228" | ||
|
||
[compat] | ||
LaTeXStrings = "^1.3" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the missing entries here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tmigot ! Sure, on it ! I was wondering what default versions are used for the [extra] entry of the main Project.toml, since the tests were working with whatever these versions were before I added the requirement feature ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/JuliaSmoothOptimizers/BenchmarkProfiles.jl/actions/runs/6907307413/job/18794184718?pr=110#step:6:46
It will take the most up-to-date version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should compat for test.jl be added there too ?