Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data structure docs #245

Open
wants to merge 3 commits into
base: ale/3.0
Choose a base branch
from
Open

Data structure docs #245

wants to merge 3 commits into from

Conversation

olynch
Copy link
Collaborator

@olynch olynch commented Sep 11, 2024

Continuation of #232.

@@ -304,6 +383,7 @@ function addexpr!(g::EGraph, se)::Id

isexpr(e) || return add!(g, VecExpr(Id[Id(0), Id(0), Id(0), add_constant!(g, e)]), false)

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olynch merge leftover

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.17%. Comparing base (0b2e6c9) to head (f7e9946).
Report is 19 commits behind head on ale/3.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           ale/3.0     #245      +/-   ##
===========================================
+ Coverage    81.06%   81.17%   +0.10%     
===========================================
  Files           19       18       -1     
  Lines         1500     1498       -2     
===========================================
  Hits          1216     1216              
+ Misses         284      282       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 24, 2024

Benchmark Results

egg-sym egg-cust MT@f7e9946c115... MT@0b2e6c9f11b... egg-sym/MT@f7e... egg-cust/MT@f7... MT@0b2e6c9f11b...
egraph_addexpr 1.46 ms 5.13 ms 5.15 ms 0.285 1
basic_maths_simpl2 12.4 ms 4.87 ms 20.4 ms 20.2 ms 0.61 0.239 0.992
prop_logic_freges_theorem 2.49 ms 1.52 ms 1.07 ms 1.06 ms 2.32 1.42 0.993
calc_logic_demorgan 60.1 μs 35 μs 77 μs 78.7 μs 0.78 0.454 1.02
calc_logic_freges_theorem 21.7 ms 11.8 ms 43.1 ms 42.6 ms 0.503 0.273 0.986
basic_maths_simpl1 5.96 ms 2.75 ms 4.73 ms 4.76 ms 1.26 0.581 1.01
egraph_constructor 0.0849 μs 0.0917 μs 0.0923 μs 0.926 1.01
prop_logic_prove1 35 ms 13.9 ms 43.3 ms 42.9 ms 0.808 0.32 0.99
prop_logic_demorgan 78.4 μs 44.7 μs 96.8 μs 97.5 μs 0.81 0.462 1.01
while_superinterpreter_while_10 18.3 ms 18.5 ms 1.01
prop_logic_rewrite 122 μs 121 μs 0.992
time_to_load 116 ms 116 ms 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

src/EGraphs/egraph.jl Outdated Show resolved Hide resolved
Co-authored-by: Alessandro Cheli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants