Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raw rack element request objects #166

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Nov 27, 2023

Prior to this change, we had the following pairs of public and private types:

Public Private
RackElementLeafSwitchRequest rawRackElementLeafSwitchRequest
RackElementLeafSwitch rawRackElementLeafSwitch
RackElementAccessSwitchRequest rawRackElementAccessSwitchRequest
RackElementAccessSwitch rawRackElementAccessSwitch
RackElementGenericSystemRequest rawRackElementGenericSystemRequest
RackElementGenericSystem rawRackElementGenericSystem
RackLinkRequest rawRackLinkRequest
RackLink rawRackLink

The primary difference between the rawXXX and rawXXXRequest types was the omitempty JSON struct tags on the Tags element, which was never required on rawXXX, because we never send that type.

This PR eliminates the rawXXXRequest types. The raw() method on both rawXXX and rawXXXRequest now both produce rawXXX.

Tests updated to exercise rack type code with and without tags.

@chrismarget-j chrismarget-j merged commit bc1e50a into main Nov 27, 2023
1 check passed
@chrismarget-j chrismarget-j deleted the eliminate-raw-rack-request-objects branch November 27, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants