Remove raw rack element request objects #166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, we had the following pairs of public and private types:
RackElementLeafSwitchRequest
rawRackElementLeafSwitchRequest
RackElementLeafSwitch
rawRackElementLeafSwitch
RackElementAccessSwitchRequest
rawRackElementAccessSwitchRequest
RackElementAccessSwitch
rawRackElementAccessSwitch
RackElementGenericSystemRequest
rawRackElementGenericSystemRequest
RackElementGenericSystem
rawRackElementGenericSystem
RackLinkRequest
rawRackLinkRequest
RackLink
rawRackLink
The primary difference between the
rawXXX
andrawXXXRequest
types was theomitempty
JSON struct tags on theTags
element, which was never required onrawXXX
, because we never send that type.This PR eliminates the
rawXXXRequest
types. Theraw()
method on bothrawXXX
andrawXXXRequest
now both producerawXXX
.Tests updated to exercise rack type code with and without tags.