Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subs is not defined #289

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Fix subs is not defined #289

merged 4 commits into from
Apr 17, 2023

Conversation

sertonix
Copy link
Contributor

@sertonix sertonix commented Jan 6, 2023

Since Atom was killed the community came together and made a fork called Pulsar.
It has updated a lot of parts in the editor.

While most packages still work some old javascript styles are not valid anymore.
This fixes a syntax error.

It would be nice if a new version with this fix could be published to the new packend. If there are any problems you can create an issue on the github repo.

@goyalyashpal
Copy link

@pfitzseb @MikeInnes can u please take a look at it 😃

lib/linter/compiled-pane.js Outdated Show resolved Hide resolved
lib/linter/pane.js Outdated Show resolved Hide resolved
@goyalyashpal
Copy link

goyalyashpal commented Apr 14, 2023

a better change, again, as suggested by @savetheclocktower at pulsar-edit/pulsar#482 (comment) is to change these 2 instances of subs to this.subs in both these files. so:

--- a/lib/linter/pane.js
+++ b/lib/linter/pane.js
@@ -11,11 +11,11 @@
   name = 'LinterPane'
 
   static activate () {
-    subs = new CompositeDisposable()
+    this.subs = new CompositeDisposable()
   }
 
   static deactivate () {
-    subs.dispose()
+    this.subs.dispose()
   }
 
   constructor (opts) {
--- a/lib/linter/compiled-pane.js
+++ b/lib/linter/compiled-pane.js
@@ -12,11 +12,11 @@
   name = 'CompiledPane'
 
   static activate () {
-    subs = new CompositeDisposable()
+    this.subs = new CompositeDisposable()
   }
 
   static deactivate () {
-    subs.dispose()
+    this.subs.dispose()
   }
 
   constructor (opts) {

@goyalyashpal
Copy link

@sertonix ping 😃

@goyalyashpal
Copy link

is this acceptable now @pfitzseb 😃 ?

@pfitzseb pfitzseb merged commit e94490b into JunoLab:master Apr 17, 2023
@goyalyashpal
Copy link

goyalyashpal commented Apr 17, 2023

Remaining steps:

  • Creating new tag with fixes
  • Publishing new update to the packend or whatever that's called
  • Modify the uber-juno package to use this fixed version (though i suppose it would use the latest version itself?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants