-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subs
is not defined
#289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
@pfitzseb @MikeInnes can u please take a look at it 😃 |
pfitzseb
requested changes
Apr 14, 2023
a better change, again, as suggested by @savetheclocktower at pulsar-edit/pulsar#482 (comment) is to change these 2 instances of --- a/lib/linter/pane.js
+++ b/lib/linter/pane.js
@@ -11,11 +11,11 @@
name = 'LinterPane'
static activate () {
- subs = new CompositeDisposable()
+ this.subs = new CompositeDisposable()
}
static deactivate () {
- subs.dispose()
+ this.subs.dispose()
}
constructor (opts) {
--- a/lib/linter/compiled-pane.js
+++ b/lib/linter/compiled-pane.js
@@ -12,11 +12,11 @@
name = 'CompiledPane'
static activate () {
- subs = new CompositeDisposable()
+ this.subs = new CompositeDisposable()
}
static deactivate () {
- subs.dispose()
+ this.subs.dispose()
}
constructor (opts) {
|
@sertonix ping 😃 |
is this acceptable now @pfitzseb 😃 ? |
pfitzseb
approved these changes
Apr 17, 2023
Remaining steps:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Atom was killed the community came together and made a fork called Pulsar.
It has updated a lot of parts in the editor.
While most packages still work some old javascript styles are not valid anymore.
This fixes a syntax error.
It would be nice if a new version with this fix could be published to the new packend. If there are any problems you can create an issue on the github repo.