Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vc-api): external subdomainRecordsFetcher error handling #87

Conversation

georgesMouawad
Copy link
Contributor

Adjusts the SubnameRecordsFetcher:

  • Makes the text param in fetchRecords required.
  • Removes (if (text) else).
  • Adds a try catch block when fetching records.

Copy link

linear bot commented Dec 11, 2024

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
telegram-static ✅ Ready (Inspect) Visit Preview Dec 13, 2024 9:17am

@Ghadi8 Ghadi8 merged commit 39128cd into develop Dec 13, 2024
3 checks passed
@georgesMouawad georgesMouawad deleted the georges/engr-729-implement-error-handling-on-records-feching-justverified branch December 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants