Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vc-api): removed unused openpassport scope #93

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/vc-api/.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ TELEGRAM_BOT_TOKEN=<YOUR_TELEGRAM_BOT_TOKEN>
TELEGRAM_BOT_USERNAME=<YOUR_TELEGRAM_BOT_USERNAME>
TELEGRAM_STATIC_PAGE_URL=<YOUR_TELEGRAM_STATIC_PAGE_URL>

OPENPASSPORT_SCOPE=<YOUR_OPENPASSPORT_SCOPE>
OPENPASSPORT_STATIC_PAGE_URL=<YOUR_OPENPASSPORT_STATIC_PAGE_URL>

DISCORD_CLIENT_ID=<YOUR_DISCORD_CLIENT_ID>
Expand Down
3 changes: 0 additions & 3 deletions apps/vc-api/src/config/env.validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ class EnvironmentVariables implements Environment{
@IsString({message: 'OPENPASSPORT_STATIC_PAGE_URL must be a string'})
OPENPASSPORT_STATIC_PAGE_URL!: string;

@IsString({message: 'OPENPASSPORT_SCOPE must be a string'})
OPENPASSPORT_SCOPE!: string;

@IsString({message: 'JWT_SECRET must be a string'})
JWT_SECRET: string;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ export class EnvironmentGetter implements IEnvironmentGetter {
return this.configService.get<string>('TELEGRAM_STATIC_PAGE_URL');
}

getOpenPassportScope(): string {
return this.configService.get<string>('OPENPASSPORT_SCOPE');
}

getOpenPassportStaticPageUrl(): string {
return this.configService.get<string>('OPENPASSPORT_STATIC_PAGE_URL');
}
Expand Down
2 changes: 0 additions & 2 deletions apps/vc-api/src/core/domain/entities/environment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ export class Environment {

OPENPASSPORT_STATIC_PAGE_URL!: string;

OPENPASSPORT_SCOPE!: string;

JWT_SECRET!: string;

ENCRYPT_KEY!: string;
Expand Down
4 changes: 0 additions & 4 deletions k8s-staging/staging-secrets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ spec:
key: DOMAIN
- objectName: telegram_static_page_url
key: TELEGRAM_STATIC_PAGE_URL
- objectName: openpassport_scope
key: OPENPASSPORT_SCOPE
- objectName: openpassport_static_page_url
key: OPENPASSPORT_STATIC_PAGE_URL

Expand Down Expand Up @@ -123,7 +121,5 @@ spec:
objectAlias: domain
- path: TELEGRAM_STATIC_PAGE_URL
objectAlias: telegram_static_page_url
- path: OPENPASSPORT_SCOPE
objectAlias: openpassport_scope
- path: OPENPASSPORT_STATIC_PAGE_URL
objectAlias: openpassport_static_page_url
5 changes: 0 additions & 5 deletions k8s-staging/vc-api-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,6 @@ spec:
secretKeyRef:
name: foosecret-verifications
key: TELEGRAM_STATIC_PAGE_URL
- name: OPENPASSPORT_SCOPE
valueFrom:
secretKeyRef:
name: foosecret-verifications
key: OPENPASSPORT_SCOPE
- name: OPENPASSPORT_STATIC_PAGE_URL
valueFrom:
secretKeyRef:
Expand Down
4 changes: 0 additions & 4 deletions k8s/secrets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ spec:
key: DOMAIN
- objectName: telegram_static_page_url
key: TELEGRAM_STATIC_PAGE_URL
- objectName: openpassport_scope
key: OPENPASSPORT_SCOPE
- objectName: openpassport_static_page_url
key: OPENPASSPORT_STATIC_PAGE_URL

Expand Down Expand Up @@ -118,8 +116,6 @@ spec:
objectAlias: domain
- path: TELEGRAM_STATIC_PAGE_URL
objectAlias: telegram_static_page_url
- path: OPENPASSPORT_SCOPE
objectAlias: openpassport_scope
- path: OPENPASSPORT_STATIC_PAGE_URL
objectAlias: openpassport_static_page_url

5 changes: 0 additions & 5 deletions k8s/vc-api-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,6 @@ spec:
secretKeyRef:
name: foosecret-verifications
key: TELEGRAM_STATIC_PAGE_URL
- name: OPENPASSPORT_SCOPE
valueFrom:
secretKeyRef:
name: foosecret-verifications
key: OPENPASSPORT_SCOPE
- name: OPENPASSPORT_STATIC_PAGE_URL
valueFrom:
secretKeyRef:
Expand Down
Loading