add [] getData #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add [] getData
JustasMasiulis
requested changes
Nov 8, 2020
| { | ||
| if (i >= N) | ||
| { | ||
| throw std::out_of_range("Array index error"); |
There was a problem hiding this comment.
Hey, sorry for not replying to your issue and thanks for the additions 👍
However, could you change the exception message to circular_buffer::at index out of range to reflect the source of exception better?
Edit: now that I'm thinking about it, it should check whether index is within bounds of valid elements, not just allocation, so that would need to be fixed too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add [] getData