Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds maximumWriteValueLength to Peripheral #809

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Adds maximumWriteValueLength to Peripheral #809

merged 6 commits into from
Dec 6, 2024

Conversation

ErikHellman
Copy link
Contributor

@ErikHellman ErikHellman commented Dec 3, 2024 •
edited by twyatt
Loading

  • Calls maximumWriteValueLength on iOS
  • Returns latest know value from onMtuChanged() - 3 on Android, or the default (23 - 3) if the callback haven't been called
  • Return default (23 -3) on Web

Closes #729

Adds maximumWriteValueLength to Peripheral JuulLabs#729
4690071 
- Calls maximumWriteValueLength on iOS
- Returns latest know value from onMtuChanged on Android, or the default (23 - 3) if the callback haven't been called
- Return default (23 -3) on Web
@ErikHellman ErikHellman requested review from twyatt and a team as code owners December 3, 2024 12:20
@twyatt twyatt changed the title Adds maximumWriteValueLength to Peripheral #729 Adds maximumWriteValueLength to Peripheral Dec 3, 2024
@twyatt twyatt added the minor Changes that should bump the MINOR version number label Dec 3, 2024
@twyatt
Copy link
Member

twyatt commented Dec 3, 2024

Note: :kable-core:androidApiCheck Gradle task failure can be fixed by running ./gradlew apiDump then pushing the updated API dump files.

@twyatt twyatt mentioned this pull request Dec 4, 2024
Open
@ErikHellman
Copy link
Contributor Author

It would be awesome if we could get this in a near release as I need this for my current project. @cedrickcooke does this solution look ok for you?

cedrickcooke
cedrickcooke approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@cedrickcooke cedrickcooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this. Yup, looks good

@twyatt twyatt added this to the 0.35.0 milestone Dec 6, 2024
@twyatt twyatt merged commit 1fce4e2 into JuulLabs:main Dec 6, 2024
2 checks passed
@twyatt
Copy link
Member

twyatt commented Dec 6, 2024 •
edited
Loading

@ErikHellman released with 0.35.0.

Note

Compared to 0.34.0, the internals include a major refactor. I believe the 0.35.0 RC releases have been out long enough to get word of any major bugs, but please don't hesitate to report any issues you come across.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twyatt twyatt twyatt approved these changes

@cedrickcooke cedrickcooke cedrickcooke approved these changes

Assignees
No one assigned
Labels
minor Changes that should bump the MINOR version number
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.

Feature request: Add maximumWriteValueLengthForType to iOS Peripheral
3 participants
@ErikHellman @twyatt @cedrickcooke