Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ctrl+LeftClick Drag panning for non-pan tools #935

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

mattkdab
Copy link
Member

Requested feature.

Enable Ctrl+Shift+LeftClick Dragging to pan the remote view when using interaction modes other than ViewInteraction.

Should close #933

Requested feature.

Enable Ctrl+Shift+LeftClick Dragging to pan the remote view
when using interaction modes other than ViewInteraction.

Should close KDAB#933
@mattkdab mattkdab requested a review from winterz January 19, 2024 00:17
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mattkdab
Copy link
Member Author

just noticed #741 is sort of the same as this?

@g-fb
Copy link

g-fb commented Jan 21, 2024

Any reason for requiring both Ctrl and Shift to be pressed?

Anyway, thank you for adding this.

@mattkdab
Copy link
Member Author

Any reason for requiring both Ctrl and Shift to be pressed?

Anyway, thank you for adding this.

Hm, right I suppose it could just be Ctrl, since this is only when not using the pan tool (Ctrl clicking with pan tool performs a Pick Element). I'll update with that change.

@Waqar144
Copy link
Contributor

related #741

@mattkdab mattkdab changed the title Feature: Ctrl+Shift+LeftClickDrag panning for non-pan tools Feature: Ctrl+LeftClick Drag panning for non-pan tools Jan 23, 2024
@mattkdab mattkdab requested a review from Waqar144 January 23, 2024 00:15
@winterz
Copy link
Contributor

winterz commented Jan 23, 2024

@mattkdab I'm stumped why the cla-assistant doesn't recognize you. I'll approve this and merge.

@winterz winterz merged commit ea79be4 into KDAB:master Jan 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick Scenes: always pan view with <modifier>+click
5 participants