Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build static probe without internal dependencies #936

Closed
wants to merge 7 commits into from
Closed

Build static probe without internal dependencies #936

wants to merge 7 commits into from
+492 −339

Conversation

Kentzo
Copy link
Contributor

@Kentzo Kentzo commented Jan 19, 2024

Adjust types of the probe dependency tree so that the final static library has no internal dependencies. Install headers, pri and cmake files.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Kentzo
❌ pre-commit-ci[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@Kentzo Kentzo force-pushed the fix-static-probe branch 4 times, most recently from 7d4daf5 to 65d6a20 Compare January 19, 2024 07:00
Kentzo added 3 commits January 18, 2024 23:03
@Kentzo
CMake: Allow custom installation directory in gammaray_add_plugin
b5c56de 
Make it a function to scope internal variables.
@Kentzo
CMake: Don't check for GAMMARAY_PROBE_ONLY_BUILD in gammaray_install_…
80696fb 
…headers

It is responsibility of the user to invoce the function where appropriate.
@Kentzo
CMake: Fix missing staticprobe.h in static probe builds.
95f84d4
@Kentzo Kentzo force-pushed the fix-static-probe branch 2 times, most recently from 7fa8b45 to 966145d Compare January 19, 2024 08:47
@Kentzo Kentzo mentioned this pull request Jan 19, 2024
Closed
@Kentzo Kentzo force-pushed the fix-static-probe branch 4 times, most recently from 0c8906b to 2d4c81a Compare January 20, 2024 06:44
@Kentzo
Copy link
Contributor Author

Kentzo commented Jan 24, 2024

I will split this PR into smaller pieces.

@Kentzo Kentzo closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kentzo @CLAassistant