Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kdt5 kim sae yeon #59

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Kdt5 kim sae yeon #59

wants to merge 9 commits into from

Conversation

saeyeonKim
Copy link

No description provided.

Copy link

@sangheon-kim sangheon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

부족한점 코멘트 드렸습니다.

node_modules... .gitignore처리 부탁드립니다.

</Routes>
</BrowserRouter>
);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout으로 만들어서 Outlet을 사용하면 더좋았을 것 같아요.

</div>
</div>
</div>
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하드코딩 하지말아주세요

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node_modules.... .gitignore처리 부탁드립니다.

<select name="years" id="" className="years">
<option value="all">All Years</option>
<option value="1985">1985</option>
<option value="1986">1986</option>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하드코딩 하지말아주세요.

}
fetchData();
}, [id]);
console.log("movie:", movie);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 로그는 배포시에는 지워주는 것을 권장드립니다.


useEffect(() => {
async function fetchData() {
const res = await fetch(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetch는 별도로 API함수 분리해서 사용해주세요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants