-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kdt5 kim sae yeon #59
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
부족한점 코멘트 드렸습니다.
node_modules... .gitignore처리 부탁드립니다.
</Routes> | ||
</BrowserRouter> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout으로 만들어서 Outlet을 사용하면 더좋았을 것 같아요.
</div> | ||
</div> | ||
</div> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하드코딩 하지말아주세요
node_modules/react/jsx-runtime.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node_modules.... .gitignore처리 부탁드립니다.
<select name="years" id="" className="years"> | ||
<option value="all">All Years</option> | ||
<option value="1985">1985</option> | ||
<option value="1986">1986</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하드코딩 하지말아주세요.
movie/src/pages/detail/Detail.jsx
Outdated
} | ||
fetchData(); | ||
}, [id]); | ||
console.log("movie:", movie); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이런 로그는 배포시에는 지워주는 것을 권장드립니다.
|
||
useEffect(() => { | ||
async function fetchData() { | ||
const res = await fetch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetch는 별도로 API함수 분리해서 사용해주세요.
No description provided.