-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI #10
Conversation
The C++ lib I was using for an HTTP Rest API was cpp-httplib What I like: It has a small footprint and lean C++ interface. Ubuntu 22.04 provides an (of course a bit outdated) apt package: libcpp-httplib-dev |
fb77cc9
to
1f8f7c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very, very nice, thanks for all the hard work!
This is a very nice and important feature and it's integrated really well. Most complaints I have are minor (and since I'm neither a JS guy nor the CMake expert between the two of us you probably know better anyway ;-) ).
The one thing I'd wish for if it is feasible without too much overhead would be the ability to configure the port of the vue app.
Also, you should update this line in the current README:
We will shortly add an [arbitration graph GUI](https://github.com/KIT-MRT/arbitration_graphs/pull/10) and a [tutorial](https://github.com/KIT-MRT/arbitration_graphs/pull/51) based on this demo – stay tuned!
I opened the PR, so you'll have to approve it yourself.
optionRx: function (options) { | ||
if (options == null || options === undefined || options.length == 0) { | ||
// This component is a behavior option → rounded edges | ||
return 10; | ||
} else { | ||
// This component is an arbitrator → square edges | ||
return 0; | ||
} | ||
}, | ||
optionRy: function () { | ||
return this.optionRx(); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, which Firefox version do you use? 🤔
The video above has been recorded from my Firefox 131.0.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, weird. I use 132.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, after updating to 132.0.1 I still don't see this issue…
…finition (didn't work)
Rebased onto main |
It's indirectly linked via arbitration_graphs_gui
Alright – now, that we don't compile the static files path into an object file, but pass it as pre-compiled header (5bc50c9), @ll-nick Please test this thoroughly on your machine (remember to disable or even prune docker caches) Also, I figured that the demo tests didn't compile anymore: 8ed4e40 As soon as you're happy with these changes, we can merge 😄 |
Alrighty, I tested everything I believe
Everything works flawlessly except for the colors of the GUI being off for me. If it works for you, I'd merge anyway and look into this in a separate issue or something. Maybe I also just need to delete some browser cache or similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving my own stuff feels weird 🙈
(Actual draft PRs are a paid feature so the title will have to do)
Adds @orzechow fancy GUI web app to the repo and the demo while replacing the ROS based communication with something more generic, probably web sockets.