-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaehyeon week1 #2
Open
fanta4715
wants to merge
16
commits into
jaehyeon
Choose a base branch
from
jaehyeon-week1
base: jaehyeon
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 테이블 구조에 맞는 Entity 생성 - BaseTimeEntity 활용해서 생성,수정시간 관리
…to jaehyeon-week1
- OneToMany로 가져오면 페이지가 복잡해져서 이점이 없다고 판단 -> 삭제
- 불필요한 OneToMany 삭제 - 필요한 OneToMany 추가
- Spring Data JPA의 쿼리 메소드 기본 검증
bayy1216
approved these changes
Mar 23, 2024
kwonssshyeon
approved these changes
Mar 25, 2024
} | ||
|
||
public MemberInfoResponse getMemberInfo(Long memberId) { | ||
memberRepository.findById(memberId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return 을 하지 않아도 Member가 반환 되나요 ?.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1주차 👍