Hongseok week1 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanta4715
approved these changes
Mar 23, 2024
|
|
||
| @Configuration | ||
| @EnableJpaAuditing | ||
| public class JpaConfig { |
There was a problem hiding this comment.
깡통 JpaConfig에 @EnableJpaAuditing을 올렸다는게 인상
|
|
||
| @Transactional | ||
| public Long createArticle(Long id, ArticleCreateRequest articleCreateRequest) { | ||
| MemberEntity member = memberJpaRepository.findById(id).orElseThrow(() -> new ResourceNotFoundException("Member", id)); |
There was a problem hiding this comment.
저라면 여기 예외처리 부분을 repository로 뺄 꺼 같긴 합니다 !
article을 만드는 것과는 분리되는 작업이라서 ..?
There was a problem hiding this comment.
말씀하신대로 레포지토리가 DB엑세스만 담당하니까 비지니스 로직인 예외처리를 서비스 레이어에서 해야하는 것도 맞는 거 같습니다
There was a problem hiding this comment.
근데 저의 개인적인 의견은
동일한 코드가 중복되어 작성될 가능성이 있고
member단일에 대한 SQL만으로도 검증이 가능한 코드이기 때문에 레포지토리 레이어에서도 해줄 수 있다고 생각했습니다
There was a problem hiding this comment.
저스트 의견...
근데 홍석님께서 쓰신 답글이 어디있었는데 못찾겟네요..허허
There was a problem hiding this comment.
다시 생각해보니 맞는의견같아서 지웠어요.. ㅎㅎ
repository에서 쓰는게 좋다고 생각했습니다!
근데 이게 코틀린처럼 확장함수를 못쓰고, 인터페이스로하려니까 꽤나 귀찮은거같아요
There was a problem hiding this comment.
메소드명은 findByIdOrThrow로 하면 깔끔할거 같습니다!
kwonssshyeon
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용