Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date with empty string and handle invalid date format during execution #21

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

rlaiola
Copy link

@rlaiola rlaiola commented Oct 16, 2024

This PR:

  • Highlights invalid date format while typing if an empty string is used as parameter of the date function;

Database Employee (Franklin University)

pi date('')->d EMPLOYEE

Before:
Screenshot 2024-10-16 at 11 04 32

After:
Screenshot 2024-10-16 at 11 03 13

  • Shows error message if the date check problem happens during execution;

Database Employee (Franklin University)

pi date(Fname)->d EMPLOYEE

Before (after clicking on the execute query):
Screenshot 2024-10-16 at 11 09 46

After:
Screenshot 2024-10-16 at 11 06 38

PS: I'd suggest reverting the changes in src/db/parser/grammar_bags.d.ts because the problem is not date-related and it will be fixed in dbis-uibk#215

@KPMGE
Copy link
Owner

KPMGE commented Oct 16, 2024

@rlaiola Thanks for the points. Great improvements!

@KPMGE KPMGE merged commit 6119c96 into KPMGE:fix-date-check Oct 16, 2024
@rlaiola rlaiola deleted the fix-date-check branch October 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants