Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Soviet contractor descriptions #2319

Merged

Conversation

Tagir-1
Copy link
Contributor

@Tagir-1 Tagir-1 commented Jan 5, 2024

  • OKB titles now feature not chief designers names, but modern proper names of OKBs.
  • Descriptions were updated with more correct historical facts
  • Logos that had generic OKB and number, now feature real, modern logos of organizations.

Titles now feature not chief designers names, but modern proper names of OKBs. Descriptions were updated with more correct history
Logos had generic OKB and number, now they feature real, modern logos of organizations.
@Capkirk123
Copy link
Member

That was an intentional choice, since the path from design bureau to the modern state enterprises wasn't always linear, and many of them had extensive changes in structure between those times.

The current system is intended to represent the contractors as they existed during the space race. Contractor options changing over time to reflect real-world changes may be implemented in the future.

@Tagir-1
Copy link
Contributor Author

Tagir-1 commented Jan 9, 2024

Oh, okay, got it. I would still like to fix some descriptions (all OKBs were reformed and renamed long before the fall of USSR), but I will exclude name and image changes

@Tagir-1 Tagir-1 marked this pull request as draft January 9, 2024 11:17
This reverts commit b2f1009.
More modern names of OKBs were removed. Reason below:
Capkirk123: The current system is intended to represent the contractors as they existed during the space race. Contractor options changing over time to reflect real-world changes may be implemented in the future.
@Tagir-1 Tagir-1 marked this pull request as ready for review February 2, 2024 20:08
@Tagir-1
Copy link
Contributor Author

Tagir-1 commented Feb 2, 2024

I've reverted names and logo changes, but I want to point out than most OKBs were renamed to modern names at around 60s-70s. So they had proper names instead of numbers long before the fall of Soviet Union.

@siimav siimav changed the title Soviet contractors logos and descriptions Improve Soviet contractor descriptions Feb 2, 2024
@siimav siimav merged commit 6aeb1e9 into KSP-RO:master Feb 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants