Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”ง [WV-12] fix: next/Image ๊ฒฝ๊ณ  ์ˆ˜์ • #14

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

Jinviz
Copy link
Member

@Jinviz Jinviz commented Dec 16, 2024

๊ฐœ์š”

next/Image ์ปดํฌ๋„ŒํŠธ ๊ฒฝ๊ณ ๋ฌธ ํ•ด๊ฒฐ

PR Checklist

PR์ด ๋‹ค์Œ ์š”๊ตฌ ์‚ฌํ•ญ์„ ์ถฉ์กฑํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

  • PR ์ œ๋ชฉ ๋ฐ ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€ ์ปจ๋ฒค์…˜ ํ™•์ธ
  • ์ง์ ‘ ๋งŒ๋“  ํ•จ์ˆ˜๊ฐ€ ์žˆ๋‹ค๋ฉด ์ด์— ๋Œ€ํ•œ ์„ค๋ช… ์ถ”๊ฐ€ (ex. JS DOCS)
  • ๋ณ€๊ฒฝ ์‚ฌํ•ญ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์™„๋ฃŒ (๋ฒ„๊ทธ ์ˆ˜์ •/๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ)
  • Label ํ™•์ธ
  • Assignees ์„ค์ • ํ™•์ธ
  • Reviewers ์„ค์ • ํ™•์ธ

PR details

๊ฒฝ๊ณ  1

image

Next13๋ฒ„์ „ ์ด์ƒ์—์„œ 'layout'๊ณผ 'object-fit' Prop์ด ์‚ญ์ œ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ํ•ด๋‹น Prop ์ œ๊ฑฐ ํ›„ style๋กœ ํ†ตํ•ฉํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๊ฒฝ๊ณ  2

image

์ด๋ฏธ์ง€ ๋น„์œจ์„ ์œ ์ง€ํ•˜๊ธฐ ์œ„ํ•ด 13๋ฒ„์ „ ์ด์ƒ๋ถ€ํ„ฐ fill={true} Prop์„ ์ œ๊ณตํ•ฉ๋‹ˆ๋‹ค. ์ด๋•Œ, ๋ถ€๋ชจ ์ปจํ…Œ์ด๋„ˆ๊ฐ€ position์ด static์ด๋ฉด ์•ˆ ๋˜๊ธฐ ๋•Œ๋ฌธ์— ์ด๋ฅผ ์ˆ˜์ •ํ•ด์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค.


When modifying code...

# Request Level
  - [ ] : "๐Ÿ”ฅ ์ด๋Œ€๋กœ Merge ํ•˜๋ฉด ์•ˆ๋ผ์š”~!"
  - [ ] : "๐Ÿฅน ๊ณ ์น˜๋ฉด ๋ถ„๋ช… ๋‚˜์•„์งˆ ๊ฒŒ ๋ถ„๋ช…ํ•ฉ๋‹ˆ๋‹ค.."
  - [ ] : "๐Ÿคท ์ˆ˜์ •ํ•˜๋ฉด ์ข‹์ง€ ์•Š์„๊นŒ์š”?"

# Description

@Jinviz Jinviz requested review from hee2323 and naelumcat December 16, 2024 07:58
@Jinviz Jinviz self-assigned this Dec 16, 2024
@Jinviz Jinviz added the fix ๋ฒ„๊ทธ์ˆ˜์ • label Dec 16, 2024
@Jinviz Jinviz changed the title [Wv-12] next/Image ๊ฒฝ๊ณ  ์ˆ˜์ • ๐Ÿ”ง [Wv-12] fix: next/Image ๊ฒฝ๊ณ  ์ˆ˜์ • Dec 16, 2024
@Jinviz Jinviz requested a review from hayoung78 December 16, 2024 07:59
@Jinviz Jinviz changed the title ๐Ÿ”ง [Wv-12] fix: next/Image ๊ฒฝ๊ณ  ์ˆ˜์ • ๐Ÿ”ง [WV-12] fix: next/Image ๊ฒฝ๊ณ  ์ˆ˜์ • Dec 16, 2024
Copy link
Contributor

@hayoung78 hayoung78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค

Copy link
Contributor

@naelumcat naelumcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธ ํ–ˆ์Šต๋‹ˆ๋‹ค.

@Jinviz Jinviz merged commit 76795b1 into dev Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix ๋ฒ„๊ทธ์ˆ˜์ •
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants