Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„ [WV-24] design : news card μ»΄ν¬λ„ŒνŠΈ 생성 #26

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

hayoung78
Copy link
Contributor

@hayoung78 hayoung78 commented Dec 23, 2024

κ°œμš”

  • newsCard μ»΄ν¬λ„ŒνŠΈ 생성
  • μ•„μ΄μ½˜κ³Ό 이미지 index 파일 생성

PR Checklist

PR이 λ‹€μŒ μš”κ΅¬ 사항을 μΆ©μ‘±ν•˜λŠ”μ§€ ν™•μΈν•˜μ„Έμš”.

  • PR 제λͺ© 및 컀밋 λ©”μ‹œμ§€ μ»¨λ²€μ…˜ 확인
  • 직접 λ§Œλ“  ν•¨μˆ˜κ°€ μžˆλ‹€λ©΄ 이에 λŒ€ν•œ μ„€λͺ… μΆ”κ°€ (ex. JS DOCS)
  • λ³€κ²½ 사항에 λŒ€ν•œ ν…ŒμŠ€νŠΈ μ™„λ£Œ (버그 μˆ˜μ •/κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈ)
  • Label 확인
  • Assignees μ„€μ • 확인
  • Reviewers μ„€μ • 확인

PR details

1. βž• WV-24 feat : iconκ³Ό images에 index 파일 생성

μ»΄ν¬λ„ŒνŠΈλ₯Ό λ§Œλ“€λ•Œ κ°™μ€κ³³μ—μ„œ Import ν•˜λŠ” 파일이 λ§Žμ•„μ Έμ„œ index.ts νŒŒμΌμ„ μ„€μ •ν–ˆμŠ΅λ‹ˆλ‹€.
@κ°€ 있으면 ν΄λ”λ‚΄μ—μ„œ κ°€μž₯ μƒλ‹¨μœΌλ‘œ μœ„μΉ˜ν•˜κΈ°λ•Œλ¬Έμ— μž˜λ³΄μ΄κ²Œλ” μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

image

μ‚¬μš©ν•˜μ‹œλ €λ©΄ μ•„λž˜μ™€ 같이 import ν•˜μ‹œλ©΄ λ©λ‹ˆλ‹€.
이름은 λ§žμΆ°μ„œ λΆˆλŸ¬μ˜€μ…”μ•Ό ν•©λ‹ˆλ‹€μš”..!
(ex, Calendar === index νŒŒμΌμ— μžˆλŠ” 이름({ default as Calendar })
image

//μ½”λ“œμ—μ„œλŠ”,,
import { Calendar, Views } from "@/assets/icons/@index";

쀑간에 μΆ”κ°€λœκ±°λ‹ˆ λ‹€λ“€ 이미지 μ‚¬μš©ν•˜μ‹ κ³³μ—μ„œ μˆ˜μ • λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.

2. πŸ’„ WV-24 design : newsCard μ»΄ν¬λ„ŒνŠΈ 생성

λ””μžμΈμ΄ 일뢀 λ³€κ²½λ˜μ—ˆμŠ΅λ‹ˆλ‹€..

κΈ°μ‘΄ figma

image

λ³€κ²½ ν›„

image

μ‚¬μš©ν•˜μ‹œλ €λ©΄, api κ°’ μ•ˆμ— λ„£μœΌλ©΄ λ¨μš”
ν˜„μž¬λŠ” μ˜ˆμ‹œλ§Œ λ„£μ–΄λ†¨μŠ΅λ‹ˆλ‹€.

      <NewsCard
        title="2024 kt wiz 73승 기념뱃지 수령"
        content="감사원은 원μž₯을 ν¬ν•¨ν•œ 5인 이상 11인 μ΄ν•˜μ˜ κ°μ‚¬μœ„μ›μœΌλ‘œ κ΅¬μ„±ν•œλ‹€. κ΅­νšŒκ°€ μž¬μ μ˜μ› 과반수의 μ°¬μ„±μœΌλ‘œ κ³„μ—„μ˜ ν•΄μ œλ₯Ό μš”κ΅¬ν•œ λ•Œμ—λŠ” λŒ€ν†΅λ Ήμ€ 이λ₯Ό ν•΄μ œν•˜μ—¬μ•Ό ν•œλ‹€. 이 ν—Œλ²•μ‹œν–‰ λ‹Ήμ‹œμ˜ λŒ€λ²•μ›μž₯κ³Ό λŒ€λ²•μ›νŒμ‚¬κ°€ μ•„λ‹Œ 법관은 제1ν•­ λ‹¨μ„œμ˜ κ·œμ •μ— λΆˆκ΅¬ν•˜κ³  이 ν—Œλ²•μ— μ˜ν•˜μ—¬ μž„λͺ…λœ κ²ƒμœΌλ‘œ λ³Έλ‹€. λͺ…λ ΉΒ·κ·œμΉ™ λ˜λŠ” μ²˜λΆ„μ΄ ν—Œλ²•μ΄λ‚˜ 법λ₯ μ— μœ„λ°˜λ˜λŠ” μ—¬λΆ€κ°€ 재판의 μ „μ œκ°€ 된 κ²½μš°μ—λŠ” λŒ€λ²•μ›μ€ 이λ₯Ό μ΅œμ’…μ μœΌλ‘œ 심사할 κΆŒν•œμ„ 가진닀."
        date={new Date("2024-12-25")}
        views={99}
      />

ν•΄λ‹Ή λΈŒλžœμΉ˜λŠ” λ‰΄μŠ€νŽ˜μ΄μ§€κΉŒμ§€ μ™„μ„±ν•΄μ„œ 마무리 ν•  μ˜ˆμ •μž…λ‹ˆλ‹€.


When modifying code...

# Request Level
  - [ ] : "πŸ”₯ μ΄λŒ€λ‘œ Merge ν•˜λ©΄ μ•ˆλΌμš”~!"
  - [ ] : "πŸ₯Ή 고치면 λΆ„λͺ… λ‚˜μ•„μ§ˆ 게 λΆ„λͺ…ν•©λ‹ˆλ‹€.."
  - [ ] : "🀷 μˆ˜μ •ν•˜λ©΄ 쒋지 μ•Šμ„κΉŒμš”?"

# Description

@hayoung78 hayoung78 added feat μƒˆλ‘œμš΄ κΈ°λŠ₯ μΆ”κ°€ design CSS λ“± μ‚¬μš©μž UI λ³€κ²½ refactor μž‘μ—…μˆ˜μ •, μ½”λ“œ μœ μ§€λ³΄μˆ˜ labels Dec 23, 2024
@hayoung78 hayoung78 self-assigned this Dec 23, 2024
Copy link
Member

@Jinviz Jinviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'@' μƒλ‹¨μœΌλ‘œ μ˜¬λ¦¬λŠ” 건 νŒμ΄λ„€μš”.
μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€.

Copy link
Contributor

@naelumcat naelumcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.

@@ -0,0 +1,31 @@
import Image from "next/image";
import exampleImage from "@/assets/images/team_about_img3.png";
import { Calendar, Views } from "@/assets/icons/@index";
Copy link
Contributor

@hee2323 hee2323 Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shadcn ui μ‚¬μš© 쀑이라 lucide-react μ‚¬μš©ν•΄μ„œ μ•„μ΄μ½˜ ν†΅μΌν–ˆμœΌλ©΄ μ’‹κ² μŠ΅λ‹ˆλ‹€
λ©”μΈνŽ˜μ΄μ§€ footer도 μˆ˜μ •ν•΄μ„œ μ˜¬λ¦¬κ² μŠ΅λ‹ˆλ‹€

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„μ΄μ½˜ μˆ˜μ • ν–ˆμŠ΅λ‹ˆλ‹Ή.

import { CalendarDays, Eye } from "lucide-react";

@hayoung78 hayoung78 merged commit 2730789 into dev Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design CSS λ“± μ‚¬μš©μž UI λ³€κ²½ feat μƒˆλ‘œμš΄ κΈ°λŠ₯ μΆ”κ°€ refactor μž‘μ—…μˆ˜μ •, μ½”λ“œ μœ μ§€λ³΄μˆ˜
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants