-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π [WV-24] design : news card μ»΄ν¬λνΈ μμ± #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@' μλ¨μΌλ‘ μ¬λ¦¬λ 건 νμ΄λ€μ.
μκ³ νμ
¨μ΅λλ€.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
νμΈνμ΅λλ€.
components/media/news-card.tsx
Outdated
@@ -0,0 +1,31 @@ | |||
import Image from "next/image"; | |||
import exampleImage from "@/assets/images/team_about_img3.png"; | |||
import { Calendar, Views } from "@/assets/icons/@index"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shadcn ui μ¬μ© μ€μ΄λΌ lucide-react μ¬μ©ν΄μ μμ΄μ½ ν΅μΌνμΌλ©΄ μ’κ² μ΅λλ€
λ©μΈνμ΄μ§ footerλ μμ ν΄μ μ¬λ¦¬κ² μ΅λλ€
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μμ΄μ½ μμ νμ΅λλΉ.
import { CalendarDays, Eye } from "lucide-react";
κ°μ
PR Checklist
PRμ΄ λ€μ μꡬ μ¬νμ μΆ©μ‘±νλμ§ νμΈνμΈμ.
PR details
1. β WV-24 feat : iconκ³Ό imagesμ index νμΌ μμ±
μ»΄ν¬λνΈλ₯Ό λ§λ€λ κ°μκ³³μμ Import νλ νμΌμ΄ λ§μμ Έμ index.ts νμΌμ μ€μ νμ΅λλ€.
@
κ° μμΌλ©΄ ν΄λλ΄μμ κ°μ₯ μλ¨μΌλ‘ μμΉνκΈ°λλ¬Έμ μ보μ΄κ²λ μΆκ°νμ΅λλ€.μ¬μ©νμλ €λ©΄ μλμ κ°μ΄ import νμλ©΄ λ©λλ€.
μ΄λ¦μ λ§μΆ°μ λΆλ¬μ€μ μΌ ν©λλ€μ..!
(ex, Calendar === index νμΌμ μλ μ΄λ¦(
{ default as Calendar }
)μ€κ°μ μΆκ°λκ±°λ λ€λ€ μ΄λ―Έμ§ μ¬μ©νμ κ³³μμ μμ λΆνλ립λλ€.
2. π WV-24 design : newsCard μ»΄ν¬λνΈ μμ±
λμμΈμ΄ μΌλΆ λ³κ²½λμμ΅λλ€..
κΈ°μ‘΄ figma
λ³κ²½ ν
μ¬μ©νμλ €λ©΄, api κ° μμ λ£μΌλ©΄ λ¨μ
νμ¬λ μμλ§ λ£μ΄λ¨μ΅λλ€.
ν΄λΉ λΈλμΉλ λ΄μ€νμ΄μ§κΉμ§ μμ±ν΄μ λ§λ¬΄λ¦¬ ν μμ μ λλ€.
When modifying code...