Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ [WV-18] feat : main page에 gallery 추가 구현 #27

Merged
merged 14 commits into from
Dec 23, 2024
Merged

Conversation

hee2323
Copy link
Contributor

@hee2323 hee2323 commented Dec 23, 2024

개요

  • main page에 gallery 추가 구현
  • 구현을 위해 필요한 임의 이미지 추가
  • shadcn ui carousel 삭제하고 tailwind css로 custom-carousel 생성

PR Checklist

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • PR 제목 및 커밋 메시지 컨벤션 확인
  • 직접 만든 함수가 있다면 이에 대한 설명 추가 (ex. JS DOCS)
  • 변경 사항에 대한 테스트 완료 (버그 수정/기능에 대한 테스트)
  • Label 확인
  • Assignees 설정 확인
  • Reviewers 설정 확인

PR details

gallery component

2024-12-23.6.36.22.mov

좌우 버튼을 이용해 carousel 계속 회전 가능합니다
가운데 이미지 클릭 시 추후 갤러리 페이지로 이동되도록 연결할 예정입니다


When modifying code...

# Request Level
  - [ ] : "🔥 이대로 Merge 하면 안돼요~!"
  - [ ] : "🥹 고치면 분명 나아질 게 분명합니다.."
  - [ ] : "🤷 수정하면 좋지 않을까요?"

# Description

@hee2323 hee2323 added feat 새로운 기능 추가 design CSS 등 사용자 UI 변경 refactor 작업수정, 코드 유지보수 remove 파일, 폴더 삭제 labels Dec 23, 2024
@hee2323 hee2323 self-assigned this Dec 23, 2024
Copy link
Member

@Jinviz Jinviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 수고하셨습니다.

Copy link
Contributor

@hayoung78 hayoung78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지된거로만 수정되면 될것같습니당

Comment on lines 3 to 5
import MainGallery from "@/assets/images/main_title_gallery.png";
import StoreBanner from "@/assets/images/store_banner.png";
import PlayerBanner from "@/assets/images/player_banner.png";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

후후후후 제꺼 머지되었으니 index 파일 사용해주라주!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가했습니당

Comment on lines 1 to 10
import CarouselImage1 from "@/assets/images/gallery1.jpeg";
import CarouselImage2 from "@/assets/images/gallery2.jpeg";
import CarouselImage3 from "@/assets/images/gallery3.jpeg";
import CarouselImage4 from "@/assets/images/gallery4.jpeg";
import CarouselImage5 from "@/assets/images/gallery5.jpeg";
import CarouselImage6 from "@/assets/images/gallery6.jpeg";
import CarouselImage7 from "@/assets/images/gallery7.jpeg";
import CarouselImage8 from "@/assets/images/gallery8.jpeg";
import CarouselImage9 from "@/assets/images/gallery9.jpeg";
import CarouselImage10 from "@/assets/images/gallery10.jpeg";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘도 추가해주라주

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가했습니당

Copy link
Contributor

@naelumcat naelumcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@hee2323 hee2323 merged commit 3d1fa3f into dev Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design CSS 등 사용자 UI 변경 feat 새로운 기능 추가 refactor 작업수정, 코드 유지보수 remove 파일, 폴더 삭제
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants