Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ’„ [WV-24] design : news page (pagination & select μΆ”κ°€) #29

Merged
merged 8 commits into from
Dec 27, 2024
Merged

πŸ’„ [WV-24] design : news page (pagination & select μΆ”κ°€) #29

merged 8 commits into from
Dec 27, 2024

Conversation

hayoung78
Copy link
Contributor

@hayoung78 hayoung78 commented Dec 27, 2024 •
edited by jira bot
Loading

κ°œμš”

πŸ’„ WV-24 design : news page (pagination & select μΆ”κ°€)


PR Checklist

PR이 λ‹€μŒ μš”κ΅¬ 사항을 μΆ©μ‘±ν•˜λŠ”μ§€ ν™•μΈν•˜μ„Έμš”.

  • PR 제λͺ© 및 컀밋 λ©”μ‹œμ§€ μ»¨λ²€μ…˜ 확인
  • 직접 λ§Œλ“  ν•¨μˆ˜κ°€ μžˆλ‹€λ©΄ 이에 λŒ€ν•œ μ„€λͺ… μΆ”κ°€ (ex. JS DOCS)
  • λ³€κ²½ 사항에 λŒ€ν•œ ν…ŒμŠ€νŠΈ μ™„λ£Œ (버그 μˆ˜μ •/κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈ)
  • Label 확인
  • Assignees μ„€μ • 확인
  • Reviewers μ„€μ • 확인

PR details

news-page ui λ””μžμΈ μΆ”κ°€λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
νŽ˜μ΄μ§€λ„€μ΄μ…˜ 적용 해보렀고 ν–ˆλŠ”λ° shadcnμ—μ„œ 아직 μ–΄μΌ€ 써야할지λͺ°λΌμ„œ 일단 μž„μ‹œλ‘œ λ°•μ•„λ†“κ² μŠ΅λ‹ˆλ‹€.

api μ—°κ²°λ˜λ©΄ select 와 ν•¨κ»˜ μž¬μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€.

μž„μ‹œλ‘œ λ‰΄μŠ€λ°μ΄ν„° constants에 λ„£μ—ˆμŠ΅λ‹ˆλ‹€.
image


When modifying code...

# Request Level
  - [ ] : "πŸ”₯ μ΄λŒ€λ‘œ Merge ν•˜λ©΄ μ•ˆλΌμš”~!"
  - [ ] : "πŸ₯Ή 고치면 λΆ„λͺ… λ‚˜μ•„μ§ˆ 게 λΆ„λͺ…ν•©λ‹ˆλ‹€.."
  - [ ] : "🀷 μˆ˜μ •ν•˜λ©΄ 쒋지 μ•Šμ„κΉŒμš”?"

# Description

@hayoung78 hayoung78 added the design CSS λ“± μ‚¬μš©μž UI λ³€κ²½ label Dec 27, 2024
@hayoung78 hayoung78 self-assigned this Dec 27, 2024
hee2323
hee2323 reviewed Dec 27, 2024
View reviewed changes
components/ui/custom-select.tsx Outdated
Comment on lines 24 to 29
<SelectLabel>Fruits</SelectLabel>
<SelectItem value="apple">Apple</SelectItem>
<SelectItem value="banana">Banana</SelectItem>
<SelectItem value="blueberry">Blueberry</SelectItem>
<SelectItem value="grapes">Grapes</SelectItem>
<SelectItem value="pineapple">Pineapple</SelectItem>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제λͺ©μ΄λž‘ λ‚΄μš© μ •λ„λ‘œ 바꿔놓아도 쒋을 것 κ°™μ•„μš©

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
νŽ˜μ΄μ§€ μ•ˆμ—΄λ¦¬λŠ”μ€„ μ•Œμ•˜μ˜€μš© μˆ˜μ • ν–ˆμŠ΅λ‹ˆλ‹€

hee2323
hee2323 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@hee2323 hee2323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹Ή
build κΉ¨μ§„κ²ƒλ§Œ 확인해μ₯¬μ„Έμš©

Jinviz
Jinviz approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@Jinviz Jinviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.

@hayoung78 hayoung78 merged commit c64972b into dev Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jinviz Jinviz Jinviz approved these changes

@hee2323 hee2323 hee2323 approved these changes

@naelumcat naelumcat Awaiting requested review from naelumcat

Assignees

@hayoung78 hayoung78

Labels
design CSS λ“± μ‚¬μš©μž UI λ³€κ²½
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hayoung78 @Jinviz @hee2323