Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ’„ [WV-36] design : λ°°λ„ˆ λ””μžμΈ κ°œμ„  #41

Merged
merged 2 commits into from
Jan 9, 2025
Merged

πŸ’„ [WV-36] design : λ°°λ„ˆ λ””μžμΈ κ°œμ„  #41

merged 2 commits into from
Jan 9, 2025

Conversation

Jinviz
Copy link
Member

@Jinviz Jinviz commented Jan 9, 2025 •
edited
Loading

κ°œμš”

μΉ΄ν…Œκ³ λ¦¬ λ°°λ„ˆ μ»΄ν¬λ„ŒνŠΈ λ””μžμΈ λ³€κ²½ν•˜μ˜€μŠ΅λ‹ˆλ‹€.


PR Checklist

PR이 λ‹€μŒ μš”κ΅¬ 사항을 μΆ©μ‘±ν•˜λŠ”μ§€ ν™•μΈν•˜μ„Έμš”.

  • PR 제λͺ© 및 컀밋 λ©”μ‹œμ§€ μ»¨λ²€μ…˜ 확인
  • 직접 λ§Œλ“  ν•¨μˆ˜κ°€ μžˆλ‹€λ©΄ 이에 λŒ€ν•œ μ„€λͺ… μΆ”κ°€ (ex. JS DOCS)
  • λ³€κ²½ 사항에 λŒ€ν•œ ν…ŒμŠ€νŠΈ μ™„λ£Œ (버그 μˆ˜μ •/κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈ)
  • Label 확인
  • Assignees μ„€μ • 확인
  • Reviewers μ„€μ • 확인

PR details


When modifying code...

이것저것 λ””μžμΈ 변경을 많이 ν•΄λ΄€μ§€λ§Œ μ‹¬ν”Œν•œ 게 제일 λ‚˜μ•„λ³΄μ˜€μŠ΅λ‹ˆλ‹€.
ν˜Ήμ—¬λ‚˜ λ³„λ‘œκ±°λ‚˜ λ§ˆμŒμ— μ•ˆ λ“€λ©΄ λ§μ”€ν•΄μ£Όμ„Έμš”..!

μˆ˜μ • μ „

image

μˆ˜μ • ν›„

image

# Request Level
  - [ ] : "πŸ”₯ μ΄λŒ€λ‘œ Merge ν•˜λ©΄ μ•ˆλΌμš”~!"
  - [ ] : "πŸ₯Ή 고치면 λΆ„λͺ… λ‚˜μ•„μ§ˆ 게 λΆ„λͺ…ν•©λ‹ˆλ‹€.."
  - [ ] : "🀷 μˆ˜μ •ν•˜λ©΄ 쒋지 μ•Šμ„κΉŒμš”?"

# Description

@Jinviz Jinviz added the design CSS λ“± μ‚¬μš©μž UI λ³€κ²½ label Jan 9, 2025
@Jinviz Jinviz self-assigned this Jan 9, 2025
hayoung78
hayoung78 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@hayoung78 hayoung78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋ이것이 μ΅œμ„ μΌκ±°κ°™κΈ΄ν•œλ°μš”,, μ–΄μ©œ μ €λ ‡κ²Œ κ΅¬λ¦΄μˆ˜κ°€μžˆλŠ”μ§€,,😞
ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€

hee2323
hee2323 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@hee2323 hee2323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹Ή

@Jinviz Jinviz requested review from hee2323 and hayoung78 January 9, 2025 04:25
@Jinviz Jinviz merged commit 4ca08e8 into dev Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naelumcat naelumcat Awaiting requested review from naelumcat

@hee2323 hee2323 Awaiting requested review from hee2323

@hayoung78 hayoung78 Awaiting requested review from hayoung78

Assignees

@Jinviz Jinviz

Labels
design CSS λ“± μ‚¬μš©μž UI λ³€κ²½
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jinviz @hee2323 @hayoung78