Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ’„[WV-43] design : create-wallpaper-page ์ถ”๊ฐ€ #51

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

naelumcat
Copy link
Contributor

@naelumcat naelumcat commented Jan 16, 2025

๊ฐœ์š”

ktwiz ๋ฉ”๋‰ด์˜ "wallpaper" page๋ฅผ ๋งŒ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค.
wallpaper ์ด๋ฏธ์ง€๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.


PR Checklist

PR์ด ๋‹ค์Œ ์š”๊ตฌ ์‚ฌํ•ญ์„ ์ถฉ์กฑํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

  • PR ์ œ๋ชฉ ๋ฐ ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€ ์ปจ๋ฒค์…˜ ํ™•์ธ
  • ์ง์ ‘ ๋งŒ๋“  ํ•จ์ˆ˜๊ฐ€ ์žˆ๋‹ค๋ฉด ์ด์— ๋Œ€ํ•œ ์„ค๋ช… ์ถ”๊ฐ€ (ex. JS DOCS)
  • ๋ณ€๊ฒฝ ์‚ฌํ•ญ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์™„๋ฃŒ (๋ฒ„๊ทธ ์ˆ˜์ •/๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ)
  • Label ํ™•์ธ
  • Assignees ์„ค์ • ํ™•์ธ
  • Reviewers ์„ค์ • ํ™•์ธ

PR details

image
wallpaper ์ด๋ฏธ์ง€ ์ฒ˜๋ฆฌ ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

image
index ํŒŒ์ผ์— ์ด๋ฏธ์ง€๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.


When modifying code...

# Request Level
  - [ ] : "๐Ÿ”ฅ ์ด๋Œ€๋กœ Merge ํ•˜๋ฉด ์•ˆ๋ผ์š”~!"
  - [ ] : "๐Ÿฅน ๊ณ ์น˜๋ฉด ๋ถ„๋ช… ๋‚˜์•„์งˆ ๊ฒŒ ๋ถ„๋ช…ํ•ฉ๋‹ˆ๋‹ค.."
  - [ ] : "๐Ÿคท ์ˆ˜์ •ํ•˜๋ฉด ์ข‹์ง€ ์•Š์„๊นŒ์š”?"

# Description

@naelumcat naelumcat added the design CSS ๋“ฑ ์‚ฌ์šฉ์ž UI ๋ณ€๊ฒฝ label Jan 16, 2025
@naelumcat naelumcat self-assigned this Jan 16, 2025
Copy link
Contributor

@hee2323 hee2323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹น

Copy link
Member

@Jinviz Jinviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request Level

  • : "๐Ÿ”ฅ ์ด๋Œ€๋กœ Merge ํ•˜๋ฉด ์•ˆ๋ผ์š”~!"
  • : "๐Ÿฅน ๊ณ ์น˜๋ฉด ๋ถ„๋ช… ๋‚˜์•„์งˆ ๊ฒŒ ๋ถ„๋ช…ํ•ฉ๋‹ˆ๋‹ค.."
  • : "๐Ÿคท ์ˆ˜์ •ํ•˜๋ฉด ์ข‹์ง€ ์•Š์„๊นŒ์š”?"

Description

์ด๋ฏธ์ง€์— ์‚ด์ง rounded ์ฒ˜๋ฆฌํ•ด์ฃผ์‹œ๋ฉด UI ๋ณด๊ธฐ์— ๋” ์ข‹์„ ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค! ์ง€๊ธˆ์€ ๋„ˆ๋ฌด ๊ธฐ์กด ํŽ˜์ด์ง€์˜ ๋”ฑ๋”ฑํ•œ ์ด๋ฏธ์ง€ ๋Š๋‚Œ์ด์–ด์„œ.. ์Šน์ธ์€ ํ•ด๋‘๊ฒ ์Šต๋‹ˆ๋‹ค ^^

@naelumcat
Copy link
Contributor Author

Request Level

  • : "๐Ÿ”ฅ ์ด๋Œ€๋กœ Merge ํ•˜๋ฉด ์•ˆ๋ผ์š”~!"
  • : "๐Ÿฅน ๊ณ ์น˜๋ฉด ๋ถ„๋ช… ๋‚˜์•„์งˆ ๊ฒŒ ๋ถ„๋ช…ํ•ฉ๋‹ˆ๋‹ค.."
  • : "๐Ÿคท ์ˆ˜์ •ํ•˜๋ฉด ์ข‹์ง€ ์•Š์„๊นŒ์š”?"

Description

์ด๋ฏธ์ง€์— ์‚ด์ง rounded ์ฒ˜๋ฆฌํ•ด์ฃผ์‹œ๋ฉด UI ๋ณด๊ธฐ์— ๋” ์ข‹์„ ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค! ์ง€๊ธˆ์€ ๋„ˆ๋ฌด ๊ธฐ์กด ํŽ˜์ด์ง€์˜ ๋”ฑ๋”ฑํ•œ ์ด๋ฏธ์ง€ ๋Š๋‚Œ์ด์–ด์„œ.. ์Šน์ธ์€ ํ•ด๋‘๊ฒ ์Šต๋‹ˆ๋‹ค ^^

image
rounded ์ฒ˜๋ฆฌ ํ•ด์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค.

@naelumcat naelumcat merged commit a2371cd into dev Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design CSS ๋“ฑ ์‚ฌ์šฉ์ž UI ๋ณ€๊ฒฝ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants