Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”§ [WV-46] fix : λ¨Έμ§€λœ API μ—”λ“œν¬μΈνŠΈ μˆ˜μ • #54

Merged
merged 1 commit into from
Jan 16, 2025
Merged

πŸ”§ [WV-46] fix : λ¨Έμ§€λœ API μ—”λ“œν¬μΈνŠΈ μˆ˜μ • #54

merged 1 commit into from
Jan 16, 2025

Conversation

Jinviz
Copy link
Member

@Jinviz Jinviz commented Jan 16, 2025 •
edited by hee2323
Loading

κ°œμš”

dev에 λ¨Έμ§€λœ μ΅œμ‹  API μ—”λ“œν¬μΈνŠΈλ₯Ό μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€.


PR Checklist

PR이 λ‹€μŒ μš”κ΅¬ 사항을 μΆ©μ‘±ν•˜λŠ”μ§€ ν™•μΈν•˜μ„Έμš”.

  • PR 제λͺ© 및 컀밋 λ©”μ‹œμ§€ μ»¨λ²€μ…˜ 확인
  • 직접 λ§Œλ“  ν•¨μˆ˜κ°€ μžˆλ‹€λ©΄ 이에 λŒ€ν•œ μ„€λͺ… μΆ”κ°€ (ex. JS DOCS)
  • λ³€κ²½ 사항에 λŒ€ν•œ ν…ŒμŠ€νŠΈ μ™„λ£Œ (버그 μˆ˜μ •/κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈ)
  • Label 확인
  • Assignees μ„€μ • 확인
  • Reviewers μ„€μ • 확인

PR details

κ°œμš”μ™€ λ™μΌν•©λ‹ˆλ‹€.


When modifying code...

# Request Level
  - [ ] : "πŸ”₯ μ΄λŒ€λ‘œ Merge ν•˜λ©΄ μ•ˆλΌμš”~!"
  - [ ] : "πŸ₯Ή 고치면 λΆ„λͺ… λ‚˜μ•„μ§ˆ 게 λΆ„λͺ…ν•©λ‹ˆλ‹€.."
  - [ ] : "🀷 μˆ˜μ •ν•˜λ©΄ 쒋지 μ•Šμ„κΉŒμš”?"

# Description

@Jinviz Jinviz added the fix λ²„κ·Έμˆ˜μ • label Jan 16, 2025
@Jinviz Jinviz self-assigned this Jan 16, 2025
@Jinviz Jinviz changed the base branch from main to dev January 16, 2025 06:44
hayoung78
hayoung78 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@hayoung78 hayoung78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. κ·Έ 맡 μͺ½μ— build warningλœ¨λŠ”κ²ƒλ„ ν•΄κ²°ν•΄μ£Όμ‹­μˆ‘

hee2323
hee2323 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@hee2323 hee2323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€

@hee2323 hee2323 merged commit b4aa61b into dev Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayoung78 hayoung78 hayoung78 approved these changes

@hee2323 hee2323 hee2323 approved these changes

@naelumcat naelumcat Awaiting requested review from naelumcat

Assignees

@Jinviz Jinviz

Labels
fix λ²„κ·Έμˆ˜μ •
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jinviz @hee2323 @hayoung78