๐[WV-44] design : create-bi-page ์ถ๊ฐ #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hee2323
reviewed
Jan 16, 2025
components/ktwiz/bi/bi-items.tsx
Outdated
Comment on lines
10
to
51
| const symbolData = [ | ||
| { | ||
| id: 1, | ||
| title: "Initial symbol", | ||
| description: | ||
| "์ด๋์ ์ฌ๋ณผ์ k์ w ๋ ๊ธ์๋ฅผ ์ด์ฉํ์ฌ ๊ฐ๋ ฅํ ๋ง๋ฒ ๋ฌธ์ฅ์ด ์ฐ์ ๋๋๋ก ๋์์ธ ํ์๊ณ , ์ ํต๊ณผ ํ๋์ ๊ฐ๊ฐ์ ์กฐํ๋ฅผ ๊ณ ๋ คํ์์ต๋๋ค. ๊ฐ์ธํจ๊ณผ ํ์๋ฅผ ํํํฉ๋๋ค.", | ||
| images: [ | ||
| { | ||
| id: "initial-white", | ||
| src: bi_Initial_symbol_white, | ||
| alt: "Initial_symbol_white", | ||
| downloadUrl: "/bi_Initial_symbol_white.png", | ||
| }, | ||
| { | ||
| id: "initial-black", | ||
| src: bi_Initial_symbol_black, | ||
| alt: "Initial_symbol_black", | ||
| downloadUrl: "/bi_Initial_symbol_black.png", | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| id: 2, | ||
| title: "Image symbol", | ||
| description: | ||
| "์ด๋ฏธ์ง ์ฌ๋ณผ์ ์ ํ์ ์ธ ๋ง๋ฒ์ฌ ์ด๋ฏธ์ง์์ ํํผํ์ฌ ํ๋์ ์ธ ๋ง๋ฒ์ฌ์ ๋ชจ์ต์ ์๋กญ๊ฒ ์ฐฝ์กฐํ์ต๋๋ค. ์ ์ํ ๊ธฐ๋๋ ฅ๊ณผ ์ ์ฐํจ์ ํํํฉ๋๋ค.", | ||
| images: [ | ||
| { | ||
| id: "image-white", | ||
| src: bi_Image_symbol_white, | ||
| alt: "Image_symbol_white", | ||
| downloadUrl: "/bi_Image_symbol_white.png", | ||
| }, | ||
| { | ||
| id: "image-black", | ||
| src: bi_Image_symbol_black, | ||
| alt: "Image_symbol_black", | ||
| downloadUrl: "/bi_Image_symbol_black.png", | ||
| }, | ||
| ], | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
์์ ํ์ผ ๋ฐ๋ก ๋ง๋ค์ด์ ์ฎ๊ธฐ๋๊ฒ ์ข์ ๊ฒ ๊ฐ์ต๋๋ค
There was a problem hiding this comment.
ใ ใ ใ ใ ใ constanstํ์ผ๋ก ์ฎ๊ฒจ์ฃผ์ญ์
There was a problem hiding this comment.
ํ์ผ ๋ฐ๋ก ๋ง๋ค์ด์ ์ฎ๊ฒจ ์ฃผ์์ต๋๋ค.
There was a problem hiding this comment.
์ ๊ฒ ์ปจ๋ฒค์ ์ด ๋ง๋์ ??
hayoung78
approved these changes
Jan 16, 2025
components/ktwiz/bi/bi-items.tsx
Outdated
Comment on lines
10
to
51
| const symbolData = [ | ||
| { | ||
| id: 1, | ||
| title: "Initial symbol", | ||
| description: | ||
| "์ด๋์ ์ฌ๋ณผ์ k์ w ๋ ๊ธ์๋ฅผ ์ด์ฉํ์ฌ ๊ฐ๋ ฅํ ๋ง๋ฒ ๋ฌธ์ฅ์ด ์ฐ์ ๋๋๋ก ๋์์ธ ํ์๊ณ , ์ ํต๊ณผ ํ๋์ ๊ฐ๊ฐ์ ์กฐํ๋ฅผ ๊ณ ๋ คํ์์ต๋๋ค. ๊ฐ์ธํจ๊ณผ ํ์๋ฅผ ํํํฉ๋๋ค.", | ||
| images: [ | ||
| { | ||
| id: "initial-white", | ||
| src: bi_Initial_symbol_white, | ||
| alt: "Initial_symbol_white", | ||
| downloadUrl: "/bi_Initial_symbol_white.png", | ||
| }, | ||
| { | ||
| id: "initial-black", | ||
| src: bi_Initial_symbol_black, | ||
| alt: "Initial_symbol_black", | ||
| downloadUrl: "/bi_Initial_symbol_black.png", | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| id: 2, | ||
| title: "Image symbol", | ||
| description: | ||
| "์ด๋ฏธ์ง ์ฌ๋ณผ์ ์ ํ์ ์ธ ๋ง๋ฒ์ฌ ์ด๋ฏธ์ง์์ ํํผํ์ฌ ํ๋์ ์ธ ๋ง๋ฒ์ฌ์ ๋ชจ์ต์ ์๋กญ๊ฒ ์ฐฝ์กฐํ์ต๋๋ค. ์ ์ํ ๊ธฐ๋๋ ฅ๊ณผ ์ ์ฐํจ์ ํํํฉ๋๋ค.", | ||
| images: [ | ||
| { | ||
| id: "image-white", | ||
| src: bi_Image_symbol_white, | ||
| alt: "Image_symbol_white", | ||
| downloadUrl: "/bi_Image_symbol_white.png", | ||
| }, | ||
| { | ||
| id: "image-black", | ||
| src: bi_Image_symbol_black, | ||
| alt: "Image_symbol_black", | ||
| downloadUrl: "/bi_Image_symbol_black.png", | ||
| }, | ||
| ], | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
ใ ใ ใ ใ ใ constanstํ์ผ๋ก ์ฎ๊ฒจ์ฃผ์ญ์
|
Jinviz
approved these changes
Jan 16, 2025
๊ฐ์ฌํฉ๋๋ค |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๊ฐ์
ktwiz ๋ฉ๋ด์ "bi" page๋ฅผ ๋ง๋ค์์ต๋๋ค.
bi ์ด๋ฏธ์ง๋ฅผ ์ถ๊ฐํ์์ต๋๋ค.
PR Checklist
PR์ด ๋ค์ ์๊ตฌ ์ฌํญ์ ์ถฉ์กฑํ๋์ง ํ์ธํ์ธ์.
PR details
๊ฒฐ๊ณผ๋ฌผ ์ ๋๋ค.
iframe
๋ถํ์ํ ์์ฑ์ ์ ๊ฑฐํ๊ณ ์ ์ฒดํ๋ฉด ๋๊ฒ๋ง ํ์์ต๋๋ค.
indexํ์ผ์ ์ด๋ฏธ์ง๋ค์ ์ถ๊ฐํ์์ต๋๋ค.
Symbol
๋ฐ๋ณต๋๋ symbol ์ฝ๋๋ฅผ ์ปดํฌ๋ํธ๋ก ๋๋์ด ๋ณด์์ต๋๋ค.
When modifying code...