Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ [WV-42] refactor : api 수정 #58

Merged
merged 2 commits into from
Jan 16, 2025
Merged

♻️ [WV-42] refactor : api 수정 #58

merged 2 commits into from
Jan 16, 2025

Conversation

hayoung78
Copy link
Contributor

@hayoung78 hayoung78 commented Jan 16, 2025 •
edited
Loading

개요

refactor : api 수정


PR Checklist

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • PR 제목 및 커밋 메시지 컨벤션 확인
  • 직접 만든 함수가 있다면 이에 대한 설명 추가 (ex. JS DOCS)
  • 변경 사항에 대한 테스트 완료 (버그 수정/기능에 대한 테스트)
  • Label 확인
  • Assignees 설정 확인
  • Reviewers 설정 확인

PR details

  • 프록시 서버 도입하면서 서버 컴포넌트에서 api 에러가 났던 부분 그냥 base url 로 설정하여 수정했습니다.
  • 프록시 서버는 클라이언트 사이드에서만 해당하는 부분이라 서버 사이드에서는 에러가 난다고 합니다.

When modifying code...

# Request Level
  - [ ] : "🔥 이대로 Merge 하면 안돼요~!"
  - [ ] : "🥹 고치면 분명 나아질 게 분명합니다.."
  - [ ] : "🤷 수정하면 좋지 않을까요?"

# Description

@hayoung78 hayoung78 added the fix 버그수정 label Jan 16, 2025
@hayoung78 hayoung78 self-assigned this Jan 16, 2025
hee2323
hee2323 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@hee2323 hee2323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니당

Jinviz
Jinviz approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Jinviz Jinviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@hayoung78 hayoung78 merged commit 602dad8 into dev Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hee2323 hee2323 hee2323 approved these changes

@Jinviz Jinviz Jinviz approved these changes

@naelumcat naelumcat Awaiting requested review from naelumcat

Assignees

@hayoung78 hayoung78

Labels
fix 버그수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hayoung78 @Jinviz @hee2323