Added driver_cs #570
Open
Added driver_cs #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `driver_CS` parameter has been added to tmc5160. The ideal driver_cs value may be found by setting the CS value on the tmc5160_calculations.xlsx spreadsheet, under the chopper tab, so that the Rsense value in the spreadsheet matches `sense_resistor` as defined in printer.cfg. While it's not necessary to change the CS value, it can be helpful to reach adequate hystersis values on high current drivers paired with low current motors. The default for this value is 31, meaning only globalscaler will be used to scale the current during normal operation. Errors will be invoked if the CS value is set too low, as the target current will not be able to be reached. Update tmc5160.py
Zeanon
requested changes
Feb 5, 2025
Zeanon
requested changes
Feb 5, 2025
klippy/extras/tmc5160.py
Outdated
| "GLOBALSCALER(%d) calculation out of bounds.\n" | ||
| "The target current can't be achieved with the given " | ||
| "CS(%d) value. Please adjust your configuration.\n" | ||
| "You most likely need to increase your driver_cs value in this case.\n" |
There was a problem hiding this comment.
Roger asked to remove this line ("you most likely need to increase your driver_CS value in this case")
I am also not sure whether the "reasonable starting point is good
@rogerlz can you chime in?
There was a problem hiding this comment.
I'd be okay removing the reasonable starting point. I'll let @rogerlz make that call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
driver_CSparameter has been added to tmc5160. The ideal driver_cs value may be found by setting the CS value on the tmc5160_calculations.xlsx spreadsheet, under the chopper tab, so that the Rsense value in the spreadsheet matchessense_resistoras defined in printer.cfg. While it's not necessary to change the CS value, it can be helpful to reach adequate hystersis values on high current drivers paired with low current motors. The default for this value is 31, meaning only globalscaler will be used to scale the current during normal operation. Errors will be invoked if the CS value is set too low, as the target current will not be able to be reached.Update tmc5160.py
Checklist