Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(e2e): catalog versions e2e weekly tests #1889

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Jan 7, 2025

No description provided.

@tplevko tplevko marked this pull request as draft January 7, 2025 14:19
@tplevko tplevko force-pushed the e2e_catalog_versions branch from 707cb77 to 82f5221 Compare January 7, 2025 14:24
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (c28ed6d) to head (194aeb7).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #1889    +/-   ##
==========================================
  Coverage     78.51%   78.51%            
  Complexity      367      367            
==========================================
  Files           469      469            
  Lines         14816    14816            
  Branches       2749     2832    +83     
==========================================
  Hits          11633    11633            
+ Misses         3095     2910   -185     
- Partials         88      273   +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tplevko tplevko marked this pull request as ready for review January 9, 2025 10:13
@tplevko tplevko force-pushed the e2e_catalog_versions branch from 038665e to 194aeb7 Compare January 17, 2025 13:52
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look goods to me 👍

I just have 2 questions:

  1. Is it possible to leave the e2e-tests.yaml file as it was, so by default weekly tests will be ignored? The goal is to have the same experience locally as on the CI
  2. Did you had the chance to check if we can use the constant from the @kaoto/camel-catalog package so the catalog versions get updated when updating the catalog?

@tplevko
Copy link
Contributor Author

tplevko commented Jan 22, 2025

1. Is it possible to leave the `e2e-tests.yaml` file as it was, so by default weekly tests will be ignored? The goal is to have the same experience locally as on the CI

The added env: grepTags=-weekly actually makes sure the weekly tests are being ignored in the PR runs. I can add this env variable also to the e2e:headless tag, so we have the same experience when running the tests locally.

2. Did you had the chance to check if we can use the constant from the `@kaoto/camel-catalog` package so the catalog versions get updated when updating the catalog?

I tried to utilize the constant, but wasn't able to use it in the test. I think this won't be a huge issue as the versions change only seldomly and the test can be updated once there is a newer version used.

@lordrip lordrip merged commit 3e1dd93 into KaotoIO:main Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants