fix(Form): Enable scrolling for Selects #1937
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating patternfly to v6, the Select component is no longer scrollable. This commit enables the scrolling back by setting the `isScrollable` attribute.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
Coverage 78.58% 78.58%
Complexity 367 367
==========================================
Files 468 468
Lines 14825 14825
Branches 2835 2817 -18
==========================================
Hits 11650 11650
+ Misses 3087 2904 -183
- Partials 88 271 +183 ☔ View full report in Codecov by Sentry. |
igarashitm
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After updating patternfly to v6, the Select component is no longer scrollable.
Changes
This commit enables the scrolling back by setting the
isScrollableattribute.