Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): Enable scrolling for Selects #1937

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Jan 23, 2025

Context

After updating patternfly to v6, the Select component is no longer scrollable.

Changes

This commit enables the scrolling back by setting the isScrollable attribute.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
After updating patternfly to v6, the Select component is no longer
scrollable.

This commit enables the scrolling back by setting the `isScrollable`
attribute.
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (3e1dd93) to head (2dc1766).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #1937    +/-   ##
==========================================
  Coverage     78.58%   78.58%            
  Complexity      367      367            
==========================================
  Files           468      468            
  Lines         14825    14825            
  Branches       2835     2817    -18     
==========================================
  Hits          11650    11650            
+ Misses         3087     2904   -183     
- Partials         88      271   +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip marked this pull request as ready for review January 23, 2025 12:59
@lordrip lordrip merged commit 102da40 into KaotoIO:main Jan 23, 2025
14 checks passed
@lordrip lordrip deleted the fix/non-scrollable-dropdown branch February 6, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants