Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade embedded Camel catalog version to 4.8.3 and 4.4.5 #1958

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

apupier
Copy link
Member

@apupier apupier commented Jan 28, 2025

No description provided.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (102da40) to head (818169d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #1958    +/-   ##
==========================================
  Coverage     78.58%   78.58%            
  Complexity      367      367            
==========================================
  Files           468      468            
  Lines         14825    14825            
  Branches       2835     2817    -18     
==========================================
  Hits          11650    11650            
+ Misses         3087     2904   -183     
- Partials         88      271   +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apupier apupier marked this pull request as ready for review January 28, 2025 14:53
@lordrip lordrip self-requested a review January 28, 2025 15:40
@lordrip
Copy link
Member

lordrip commented Jan 28, 2025

We need to update this test as well, at least while we find a way to reuse the same object in both places.

@apupier
Copy link
Member Author

apupier commented Jan 28, 2025

We need to update this test as well, at least while we find a way to reuse the same object in both places.

why the test has not failed on the PR checks?

@apupier apupier force-pushed the updateDefaultCatalogVersions branch from 2658b52 to 818169d Compare January 28, 2025 15:52
@lordrip
Copy link
Member

lordrip commented Jan 28, 2025

We need to update this test as well, at least while we find a way to reuse the same object in both places.

why the test has not failed on the PR checks?

Because it runs weekly

@lordrip
Copy link
Member

lordrip commented Jan 28, 2025

Thanks for updating it @apupier

@lordrip lordrip merged commit ed14c73 into KaotoIO:main Jan 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants