chore(tests): Cache JavaType to Camel model map #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lordrip
merged commit e334242
into
KaotoIO:feat/form-with-anyof-support
4 of 8 checks passed
apupier
reviewed
Jan 29, 2025
|
|
||
| public class CamelCatalogSchemaEnhancer { | ||
|
|
||
| private final CamelCatalog camelCatalog; | ||
| private final Map<String, String> JAVA_TYPE_TO_MODEL_NAME = new LinkedHashMap<>(); |
There was a problem hiding this comment.
unless specific constraints (like we want to keep the order for keys inserted), it is better to use HashMap as it is faster
There was a problem hiding this comment.
Ah, I didn't know, I'll change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.