feat(Form): Add EnumField #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tplevko
force-pushed
the
add_enum_field
branch
from
f15df55 to
48e6497
Compare
lordrip
reviewed
Jan 30, 2025
| @@ -57,6 +58,7 @@ export const Typeahead: FunctionComponent<TypeaheadProps> = ({ | |||
| const onTextInputClear = () => { | |||
| setInputValue(''); | |||
| setIsOpen(true); | |||
| onCleanInput(); | |||
There was a problem hiding this comment.
This object could be undefined when using the TypeaheadField outside of the EnumField scope.
Suggested change
| onCleanInput(); | |
| onCleanInput?.(); |
Comment on lines
33
to
37
| if (!isDefined(item)) { | ||
| onChange(undefined); | ||
| return; | ||
| } | ||
| onChange(item.name); |
There was a problem hiding this comment.
We could simplify it to:
Suggested change
| if (!isDefined(item)) { | |
| onChange(undefined); | |
| return; | |
| } | |
| onChange(item.name); | |
| onChange(item?.name); |
| name: String(item), | ||
| description: '', | ||
| value: String(item), | ||
| })) || [], |
There was a problem hiding this comment.
Suggested change
| })) || [], | |
| })) ?? [], |
32 tasks
tplevko
force-pushed
the
add_enum_field
branch
from
48e6497 to
e8ad2b6
Compare
|
lordrip
merged commit 92da3c1
into
KaotoIO:feat/form-with-anyof-support
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add support for EnumField
part of: #1939