Make libnuma into a soft dependency #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurp
force-pushed
the
feature/soft-dep-on-libnuma
branch
from
9d6d837 to
eaa52df
Compare
|
Should I add a CI job which runs |
ddn0
approved these changes
Apr 30, 2021
The script was using a fixed path to the version_file in one case instead of using the detected one. Fixes: KatanaGraph#185
If loading fails we behave the same as if numa_available() returns false.
arthurp
force-pushed
the
feature/soft-dep-on-libnuma
branch
from
eaa52df to
356f3ba
Compare
I was already editing it, so it seemed like a good idea.
arthurp
force-pushed
the
feature/soft-dep-on-libnuma
branch
from
356f3ba to
3cb2d0c
Compare
arthurp
commented
Apr 30, 2021
Comment on lines
+116
to
+122
| strategy: | ||
| matrix: | ||
| image: | ||
| - ubuntu:16.04 | ||
| - ubuntu:latest | ||
| - centos:7 | ||
| - centos:latest |
There was a problem hiding this comment.
@ddn0 Did I over do the docker image matrix? Should I include anything else? They take about 5min each and all run in parallel after build_and_test_conda_package finishes.
There was a problem hiding this comment.
I might add ubuntu:18.04 and ubuntu:20.04 explicitly (in addition to ubuntu:latest). But I don't have a strong preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
dlopento get the 3 symbols we need fromlibnuma. If the load fails we just assume NUMA information is not available and use the existing "assume sockets are nodes" fallback. All this allows katana built with libnuma to run on machines that don't have it.Fixes: #185 (because I ran into it while doing this PR).
Fixes: ENG-324