enable ArrowVisitor on arrow::NullType #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmawhirter
force-pushed
the
fix/visit-null
branch
from
1051710 to
2569f4f
Compare
|
Resolves #10 while I'm here, json_checker moved to enterprise a while ago |
|
Relevant to #25 |
witchel
approved these changes
May 27, 2021
Up to this point we haven't, partially due to this limitation. Query has a use case that wants them now though (Cypher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handling NullType allows for typeless-nulls, like the Cypher
nullkeyword.A Scalar (
std::shared_ptr<arrow::Scalar>) can be verified to be null in several ways:scalar->type->Equals(arrow::null())(typeless null)scalar->type->id() == arrow::Type::NA(typeless null)dynamic_cast<arrow::NullScalar*>(scalar.get()) != nullptr(typeless null)scalar->is_valid == false(possibly typed null)