Remove LIMIT 1 for fetchOne

[jasin755]

setMaxResult(1) limits oneToMany/manyToMany associations.

[fprochazka]

I'm not entirely sure about this... I know this criples toMany relations, but shouldn't it be a bit smarter? This might be a BC Break for some people. Better would be to use the doctrine paginator tool to fetch only first row.

[enumag]

Which makes this a duplicate of #118.

[fprochazka]

Not really, since this is trying to solve it.

[jasin755]

In my opinion, fetchOne would be equivalent to getOneOrNullResult.

[fprochazka]

@jasin755 I agree. But the problem is, what will it do, when I only remove the setMaxResults(1) and then run a query that returns more than one result? It throws. Which is a BC break.

Now that I think about it, I've opened 3.0-dev, so I might actually break it a bit.

[jasin755]

I would not see a problem in the exception. If used fetchOne and return to more rows the comrade made a mistake somewhere and can help him to reveal it (eg. by adding limit to query object)

[jasin755]

Are you going to merge with 3.0@dev ?

[fprochazka]

I probably will.

[matej21]

yep, it is a bc break :\

Any idea how to setup maxResults? I cannot override fetchOne because getQuery is private..

[fprochazka]

@matej21 what is your use case? do you wanna fetch one specific row, or just the first row from some result?

[matej21]

@fprochazka I wanna fetch first row from the result

[fprochazka]

It was stupid of me to merge this in a hurry.

I'm reverting this 022976d and will tag v3.0.1 with the revert as a fix of the BC.
I'm also adding a new commit ed3ea61 that allows overriding the fetchOne, so you can change the behaviour if you know what you're doing (but you shouldn't, since that kills performance).