Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement llm2vec models #191

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jalkestrup
Copy link

Implemented new model class llm2vec to support various models based on the llm2vec approach and existing package https://github.com/McGill-NLP/llm2vec.

Added the first 2 models under the name TTC, a un-uspervised and a supervised model both trained on danish/scandinavian languages.

Dependencies can be installed with seb[llm2vec].

Known issue with attempting to install and run on CPU due to issues with flash-attn.

Copy link
Owner

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good. Will you add the results as well?

src/seb/registered_models/llm2vec_models.py Outdated Show resolved Hide resolved
src/seb/registered_models/llm2vec_models.py Outdated Show resolved Hide resolved
src/seb/registered_models/llm2vec_models.py Outdated Show resolved Hide resolved
src/seb/registered_models/llm2vec_models.py Outdated Show resolved Hide resolved
@jalkestrup
Copy link
Author

Generally looking good. Will you add the results as well?

Results have been added in this latest update.

Copy link
Owner

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - assuming tests pass this will merge in

@KennethEnevoldsen
Copy link
Owner

Seems like you need to run make lint and that you have a type error (you can add from __future__ import annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants