Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Practice_II_Display: Add lcd driver #162

Open
wants to merge 2 commits into
base: Bekir.Bekirov
Choose a base branch
from
Open

Practice_II_Display: Add lcd driver #162

wants to merge 2 commits into from

Conversation

BekirovBekir
Copy link

The device_tree_overlay directory contains overlay for the lcd that connected to the spi0 bus.
The driver is created two files into a sysfs:

  1. lcd_st7735s/fill_screen - fills whole screen with color (e.g. echo 0xf800 > /sys/class/lcd_st7735s/fill_screen)
  2. lcd_st7735s/fill_rect - fills rectangular area with color (e.g. echo "0x03e0 30 30 50 50" > /sys/class/lcd_st7735s/fill_rect).

@BekirovBekir BekirovBekir added the ready The PR is ready for review (set by author). label Jan 12, 2020
@yekovalyov
Copy link
Contributor

Is the framebuffer interface implemented by this code?

@yekovalyov yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Jan 13, 2020
@BekirovBekir BekirovBekir added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Jan 14, 2020
@yekovalyov
Copy link
Contributor

Please remove binary files like Practice_02-display/user_space_test_program/fbtest from repository.

@BekirovBekir BekirovBekir force-pushed the practice_lcd branch 3 times, most recently from 0a7fb8a to 8473580 Compare January 14, 2020 22:41
@BekirovBekir
Copy link
Author

The fixes related to recent comments have been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yekovalyov yekovalyov yekovalyov left review comments

Assignees
No one assigned
Labels
ready The PR is ready for review (set by author).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BekirovBekir @yekovalyov