fix : 모바일에서 차트 깨지던 현상 해결, ios 기기일 때 모바일 하단 넷바에 padding bottom 줌 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 368-fix-broken-charts-on-mobile
3 tasks
godhyzzang
reviewed
Dec 6, 2024
Comment on lines
+131
to
+134
| setIos(/iPhone|iPad|iPod/i.test(navigator.userAgent)); | ||
| } | ||
| }, []); | ||
|
|
There was a problem hiding this comment.
iphone중에서도 iphone x, 12, 13 등 특정 버전만 notch가 있는 것 같던데 이 특정한 버전인 경우에만 padding을 주는 건 힘든가요?
There was a problem hiding this comment.
아하 notch가 아니라 아래 부분에 튀어나온 swipe 아이콘(?) 이 가리는 경우를 방지하기 위한 코드이군요~ 그러면 iphone인 경우만 적용해주는 지금 코드로 적절할 것 같네요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description of the PR
🔧 What has been changed?
📸 Screenshots / GIFs (if applicable)
✅ Checklist