-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 주기정보저장시 차량정보의 위경도값 저장하도록 수정 #285
The head ref may contain hidden characters: "fix/#271-\uC8FC\uAE30\uC815\uBCF4\uC800\uC7A5\uC2DC-\uCC28\uB7C9\uC815\uBCF4\uC758-\uC704\uACBD\uB3C4\uAC12\uC800\uC7A5\uD558\uB3C4\uB85D\uC218\uC815"
Conversation
…is를 설치하는 분도 있기때문에 주석처리함)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 남겼습니다! 확인해주세요
monicar-collector/src/main/java/org/collector/application/CycleInfoService.java
Outdated
Show resolved
Hide resolved
monicar-collector/src/main/java/org/collector/common/constant/CycleInfoSize.java
Outdated
Show resolved
Hide resolved
monicar-collector/src/main/java/org/collector/consumer/CycleInfoConsumer.java
Outdated
Show resolved
Hide resolved
monicar-collector/src/main/java/org/collector/presentation/CycleInfoController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
레디스 컨테이너 추가하신 것 좋네요👍
JPA 영속성 컨텍스트 변경 감지 활용하셨군요
고생하셨습니다
monicar-collector/src/main/java/org/collector/consumer/CycleInfoConsumer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
🔧 어떤 작업인가요?
주기정보저장시 차량정보의 위경도값 저장하도록 수정
#️⃣ 연관된 이슈
#271
💡 리뷰어에게 하고 싶은 말
[기존 데이터 타입 : 기본타입 -> 참조타입으로 변경]
[주기정보저장시 차량정보의 위경도값저장하도록수정]
-> 60개가 아니라면, 예외처리하도록 코드 수정하였습니다.
[docker-compose에 redis관련 설정 추가 -> 해당 부분 주석 처리]
[cycle-info-request.json]
🙏 아래 내용이 모두 충족 되었는지 확인해주세요 🙏
dev
브랜치 병합 하셨나요?