Feat : 다가오는 크루일정 (조회/세팅조회/세팅수정) 구현 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkkapuq
approved these changes
Apr 30, 2024
Comment on lines
-126
to
+133
| MeetingMemberDto meetingMemberDto = MeetingMemberDto.of(MeetingMemberPK.of(userId, meetingDto.id())); | ||
| meetingMemberStore.removeMember(meetingMemberDto.toEntity()); | ||
| meetingMemberStore.removeMember(userId, meetingDto.id()); |
There was a problem hiding this comment.
미팅 멤버를 조회할 때 객체로 처리하지않고 id로 바로 처리하도록 바꾸신 이유가 궁금합니다!
There was a problem hiding this comment.
아하 작업하다가 CrewMember에 meetingViewed를 추가했어야 하는데, MeetingMember에 추가했었다가 같이 수정된 사항이네요..!
저 경우에 기존의 코드는 MeetingMemberDto를 생성하고 MeetingMember 엔티티로 바꿔서 삭제하고 있었습니다.
그러나 이번의 CrewMember에 meetingViewed가 추가된 것처럼, MeetingMember의 추가확장성을 고려했을 때는
엔티티로 바꿔서 수정할 필요 없이 복합키 기준인 userId와 meetingId로 삭제하는 것이 바람직하다고 생각했습니다!
(기존의 방식을 따르기 위해서는, 이외의 필드들을 조회하고 삭제 전에 정확한 값을 삭제할 엔티티에 담아야하는 불필요한 로직이 발생하기 때문입니다.)
Comment on lines
+84
to
+89
| List<MyMeetingResponse> response = userFacade.getMeetingsByUserId(userPrincipal.id()); | ||
|
|
||
| return ApiResponse.of(UserMessage.USER_MEETINGS_READ.getMessage(), response); |
There was a problem hiding this comment.
list라서 responses 가 좋을 것 같습니다! (매우 사소)
There was a problem hiding this comment.
이런 피드백 언제나 대환영입니다 ㅋㅋㅋ (진심)
반영 완료했습니다~!
This reverts commit 0a435fd.
GBGreenBravo
force-pushed
the
feature/#446_My_Upcoming_Crew_Meetings
branch
from
475b1ac to
4995905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
db : 크루모임 조회정보 저장용 필드(meeting_viewed) 추가
crew_member 테이블에 meeting_viewed의 Boolean 필드로 추가해놨습니다.
feat : 다가오는 크루일정 "조회" 구현
feat : 다가오는 크루일정 "세팅 조회 및 수정" 구현
closed #446
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.