Remove ee certs after web systemtests #813
Open
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up EE certs after tests
Clean up EE certs after tests
Remove EE certs as a test CA is removed.
Remove EE certs as test CA is removed.
Replaced a hard-coded port reference of "8080"
Replacing hard-coded reference to port 8080.
Remove EE certs after testcase test08OcspEcdsaGood().
|
Thanks for looking into this. We run tests in ephemeral containers nowadays so are not sensitive for left over certs. But clean-up is of course best practice still. |
primetomas
reviewed
Feb 27, 2025
modules/systemtests/src-test/org/cesecore/junit/util/CryptoTokenRunner.java
Outdated
Show resolved
Hide resolved
primetomas
reviewed
Feb 27, 2025
modules/systemtests/src-test/org/ejbca/core/protocol/cmp/CmpTestCase.java
Outdated
Show resolved
Hide resolved
primetomas
reviewed
Feb 27, 2025
modules/systemtests/src-test/org/ejbca/core/protocol/cmp/CrmfRARequestSystemTest.java
Outdated
Show resolved
Hide resolved
primetomas
reviewed
Feb 27, 2025
modules/systemtests/src-test/org/ejbca/core/protocol/ocsp/ProtocolOcspHttpSystemTest.java
Outdated
Show resolved
Hide resolved
|
Added some review comments. |
|
Reverts files that no longer need a change. Much simpler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
After running the "web" system tests, there are many test EE certs left behind. I've added some extra clean up code, generally at the time of the test CA removal.
I also found a few OCSP tests cases that have hard-coded references to port 8080. I've changed these to the the systemtest configuration file.
How has this been tested?
Ran "ant test:runweb" and checked for any faliures/errors, then checked the EJBCA's CertificateData table for any new certificates left behind..
Checklist before requesting a review
See also Contributing Guidelines.