Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revision for lesson 1 and landing page #10

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

kevinb-khan
Copy link
Contributor

Summary:

This revision is based on feedback from https://docs.google.com/document/d/1q4SON_aZOudU89h5zDBtDciIc9DzbTP4G884_G2MvZw/edit.

Issue: None

Test plan:

  • yarn dev
  • see that there are no webpack errors
  • see that the images show up as expected
  • see that the exercise and solution behave as expected

@kevinb-khan kevinb-khan self-assigned this Jul 3, 2024
@kevinb-khan kevinb-khan requested a review from beaesguerra July 3, 2024 15:57
Copy link
Member

@beaesguerra beaesguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates!

render() {
return <ChildComponent
user={user}
// A new function will be pass to `onClick` each time
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// A new function will be pass to `onClick` each time
// A new function will be passed to `onClick` each time

@kevinb-khan kevinb-khan merged commit 532341f into main Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants