Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colors to output of pre-commit hook #10

Open
wants to merge 3 commits into
base: FEI-5966-2
Choose a base branch
from

Conversation

lillialexis
Copy link
Member

@lillialexis lillialexis commented Nov 13, 2024

Summary:

Helps you see errors and links better

Screenshot 2024-11-12 at 5 05 22 PM

Issue: FEI-5966

Test plan:

See screenshot

@lillialexis lillialexis self-assigned this Nov 13, 2024
@lillialexis lillialexis requested a review from a team November 13, 2024 01:04
Copy link
Member

@csilvers csilvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe. Both red and blue show up against white and black backgrounds. (I have huge problems with yellow.)

@@ -35,30 +40,28 @@ fi

# Check if we are in the middle of a rebase
if [ -d ".git/rebase-merge" ] || [ -d ".git/rebase-apply" ]; then
echo "Currently in the middle of a rebase."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to take this out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants