Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Tweak strings for Segment and Angle graphs #2279

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Mar 4, 2025

Summary:

Segment

  • Update segment so that a singular segment doesn't have multiple layers of redundant labels (keep this for multiple segments)

Angle

  • Update angle so the vertex point always reads the angle, not only when "show angles" is turned on.

Issue: none

Test plan:

yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/segment.test.tsx
yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/angle.test.tsx

Storybook

@nishasy nishasy self-assigned this Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Size Change: +1 B (0%)

Total Size: 872 kB

Filename Size Change
packages/perseus/dist/es/index.js 367 kB +10 B (0%)
packages/perseus/dist/es/strings.js 6.73 kB -9 B (-0.13%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39.7 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 11.1 kB
packages/math-input/dist/es/index.js 78.2 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 29.9 kB
packages/perseus-editor/dist/es/index.js 276 kB
packages/perseus-linter/dist/es/index.js 22.8 kB
packages/perseus-score/dist/es/index.js 20.6 kB
packages/pure-markdown/dist/es/index.js 4.14 kB
packages/simple-markdown/dist/es/index.js 13.1 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Mar 4, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (5a4d546) and published it to npm. You
can install it using the tag PR2279.

Example:

pnpm add @khanacademy/perseus@PR2279

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2279

@nishasy nishasy marked this pull request as ready for review March 4, 2025 22:25
Copy link
Member

@catandthemachines catandthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it!

@nishasy nishasy merged commit e02cc41 into main Mar 5, 2025
8 of 13 checks passed
@nishasy nishasy deleted the update-single-segment branch March 5, 2025 02:02
handeyeco pushed a commit that referenced this pull request Mar 5, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/[email protected]

### Major Changes

- [#2226](#2226)
[`909148cdc`](909148c)
Thanks [@handeyeco](https://github.com/handeyeco)! - Answerless
Expression: Expression can render and is interactive with answerless
data

### Patch Changes

- Updated dependencies
\[[`a0aee41b6`](a0aee41),
[`909148cdc`](909148c)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Major Changes

- [#2233](#2233)
[`a0aee41b6`](a0aee41)
Thanks [@handeyeco](https://github.com/handeyeco)! - RadioWidget v2 in
support of answerless Radio

### Patch Changes

- [#2279](#2279)
[`e02cc4109`](e02cc41)
Thanks [@nishasy](https://github.com/nishasy)! - [SR] Tweak strings for
Segment and Angle graphs


- [#2270](#2270)
[`941343ee3`](941343e)
Thanks [@catandthemachines](https://github.com/catandthemachines)! -
Fixing side snapping within polygons to be keyboard accessible.


- [#2226](#2226)
[`909148cdc`](909148c)
Thanks [@handeyeco](https://github.com/handeyeco)! - Answerless
Expression: Expression can render and is interactive with answerless
data

- Updated dependencies
\[[`a0aee41b6`](a0aee41),
[`909148cdc`](909148c)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Major Changes

- [#2233](#2233)
[`a0aee41b6`](a0aee41)
Thanks [@handeyeco](https://github.com/handeyeco)! - RadioWidget v2 in
support of answerless Radio


- [#2226](#2226)
[`909148cdc`](909148c)
Thanks [@handeyeco](https://github.com/handeyeco)! - Answerless
Expression: Expression can render and is interactive with answerless
data

## @khanacademy/[email protected]

### Minor Changes

- [#2226](#2226)
[`909148cdc`](909148c)
Thanks [@handeyeco](https://github.com/handeyeco)! - Answerless
Expression: Expression can render and is interactive with answerless
data

### Patch Changes

- [#2233](#2233)
[`a0aee41b6`](a0aee41)
Thanks [@handeyeco](https://github.com/handeyeco)! - RadioWidget v2 in
support of answerless Radio

- Updated dependencies
\[[`e02cc4109`](e02cc41),
[`941343ee3`](941343e),
[`a0aee41b6`](a0aee41),
[`909148cdc`](909148c)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

- Updated dependencies
\[[`a0aee41b6`](a0aee41),
[`909148cdc`](909148c)]:
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

- Updated dependencies
\[[`a0aee41b6`](a0aee41),
[`909148cdc`](909148c)]:
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

- Updated dependencies
\[[`a0aee41b6`](a0aee41),
[`909148cdc`](909148c)]:
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

- Updated dependencies
\[[`a0aee41b6`](a0aee41),
[`909148cdc`](909148c)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

- Updated dependencies
\[[`a0aee41b6`](a0aee41),
[`909148cdc`](909148c)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants