Fix sync-dependencies.ts script
#2291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 876 kB ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (464b691) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2291If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2291 |
catandthemachines
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Approved, just make sure to clean up the changes to sync-dependencies.ts, add a changeset, and run pnpm test -update. Thanks @handeyeco !
utils/sync-dependencies.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| if (!packagesInThisRepo.some((name) => name === pkgName)) { |
There was a problem hiding this comment.
nit: Add back the comment here.
utils/sync-dependencies.ts
Outdated
| @@ -72,6 +79,7 @@ function main(argv: string[]) { | |||
| const workspace = yaml.parse( | |||
| fs.readFileSync("pnpm-workspace.yaml", "utf-8"), | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
nit: delete this new line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There was an issue with the
sync-dependencies.tsscript not updating deps.See: https://khanacademy.slack.com/archives/C01AZ9H8TTQ/p1741217837106749