-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT - DO NOT REVIEW YET] Update Toolbar
to use CSS grid
#2361
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5ad3532 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +31 B (+0.03%) Total Size: 101 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-ymgmpxrcfk.chromatic.com/ Chromatic results:
|
Toolbar
to use CSS gridToolbar
to use CSS grid
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (eea0853) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2361" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2361 |
Summary:
This PR makes it so elements passed to the
title
of aToolbar
can setmax-width: 100%
to ensure the title never overlapsleftContent
orrightContent
.Issue: AX-315
Test plan:
Check out the
Toolbar
stories