add flow-coverage script, add aphrodite flow types #249
Conversation
|
Deploy preview for wonder-blocks ready! Built with commit 8065a63 |
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 85.91% 85.17% -0.74%
==========================================
Files 103 103
Lines 1363 1376 +13
Branches 277 277
==========================================
+ Hits 1171 1172 +1
- Misses 163 175 +12
Partials 29 29
Continue to review full report at Codecov.
|
…x resulting flow errors
| @@ -15,9 +15,6 @@ const styles = StyleSheet.create({ | |||
| row: { | |||
| flexDirection: "row", | |||
| }, | |||
| strutLike: { | |||
| /** | ||
| * This is a labeled 🔘 or ☑️ item. This is an internal component that's wrapped | ||
| * by ChoiceField or Choice. Choice should be used in a CheckboxGroup or in a | ||
| * RadioGroup. ChoiceField is the variant used outside of such a group. The two | ||
| * are different to allow for more explicit flow typing. Choice has many of its | ||
| * props auto-populated, but ChoiceField does not. | ||
| */ | ||
| export default class ChoiceInternal extends React.Component<Props> { | ||
| */ export default class ChoiceInternal extends React.Component<Props> { |
There was a problem hiding this comment.
This is the weird spacing issue that @wishdasher was seeing with Prettier, would be good to fix this! Maybe we need to upgrade Prettier?
There was a problem hiding this comment.
Updating prettier does not resolve this issue.
There was a problem hiding this comment.
It seems like this would be pretty easy to fix, just add a rule that states code should not appear on a line after a block comment.
There was a problem hiding this comment.
I'm going to leave this as is otherwise we'll end up with this change the next time someone edits this file.
package.json
Outdated
| @@ -29,6 +30,10 @@ | |||
| "author": "", | |||
| "license": "MIT", | |||
| "devDependencies": { | |||
| "//": [ | |||
There was a problem hiding this comment.
🛑 Hmm - this got moved. Maybe you could move it out of devDependencies and update to specifically reference enzyme-adapter-react-16?
There was a problem hiding this comment.
Thanks for noticing this. I guess I'll avoid running yarn add in the future.
There was a problem hiding this comment.
I guess if we follow the same pattern as the package.json in webapp this shouldn't be an issue.
😭 |
Adding aphrodite.flow.js bumped our flow coverage from 85% to 91%. This was computed using the
flow-coverage-reportnpm package. It doesn't support lcov yet so we can't upload the reports to codecov. See rpl/flow-coverage-report#67. In the meantime you can run it manually withyarn run flow-coverage.TODO:
flowtype/no-types-missing-file-annotationeslint rule// @flowto files missing itflowerrors.