Add: Recognize Apple9 #2107
Merged
Add: Recognize Apple9 #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhollings
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix to recognize Apple9 and some format changes.
The feature set tables list 'All' for every 32-bit format on Apple9.
I also noticed that
RG32UintandRG32Sinthave MSAA (since Apple7) and Atomic (since Apple8). The Atomic one is not listed in the MVK code at all, while MSAA relies on thesupports32bitMSAAfunction. Though I am not sure that's correct, since the MSAA capabilities don't line up with the other formats. Is this intended?