Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't update currentExtent of headless surface when swapchain attached. #2141

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Don't update currentExtent of headless surface when swapchain attached. #2141

merged 1 commit into from
Jan 26, 2024

Conversation

billhollings
Copy link
Contributor

@billhollings billhollings commented Jan 26, 2024 •
edited
Loading

Fixes #2129.

@billhollings billhollings requested a review from cdavis5e January 26, 2024 17:53
@billhollings billhollings mentioned this pull request Jan 26, 2024
Closed
cdavis5e
cdavis5e approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small issue I caught.

Docs/Whats_New.md Outdated Show resolved Hide resolved
@billhollings billhollings merged commit d4d5dcb into KhronosGroup:main Jan 26, 2024
6 checks passed
@billhollings billhollings deleted the surface-extent branch January 26, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavis5e cdavis5e cdavis5e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Once a swapchain is bound to a headless surface, its currentExtent is no longer -1
2 participants
@billhollings @cdavis5e