Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory management issue in MVKSwapchain #2400

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

NekoAsakura
Copy link
Contributor

#2399
Fix memory management issue in MVKSwapchain

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2024

CLA assistant check
All committers have signed the CLA.

@cdavis5e cdavis5e merged commit 1d2ec63 into KhronosGroup:main Dec 1, 2024
6 checks passed
@gnattu
Copy link

gnattu commented Jan 22, 2025

I'm afraid this change alone is not enough to fix the problem described in #2399. It appears that CAEDRMetadata is also a managed objc object which the autorelease pool might trying to release and still cause the double free crash. Chromium does not do explicit release on this object and I think we should do the same.

This is already reproducible by using mpv with gpu-next and target-colorspace-hint=yes, play an HDR file, enter the full screen then quit the full screen, then close the player, you would see a segfault. This segfault disappears after removing the explicit release of CAEDRMetadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants