Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to C++ packages #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmha
Copy link
Contributor

@mmha mmha commented May 12, 2019

This will conflict with #61, but I'd like to start the discussion and fix the merge conflict on this PR later on. Additionally, it depends on #66 for the CMake description to make sense.

A big part of usability is to get the library running inside of the development environment fast and easy. Even though the Khronos Group does not maintain the packages for the two big C++ package managers, we should give developers a hint on how they can integrate OpenCL into their project using vcpkg or Conan + CMake.

Who wants to read build scripts and search the internet for the availability of a package to find out how to consume a library?

For reference:

  • As of now, I am maintaining the Conan package
  • As of now, @MathiasMagnus is maintaining the vcpkg package

@bashbaug
Copy link
Contributor

This seems like a reasonable thing to do. I'd personally prefer to put the links to C++ packages towards the bottom of the README vs. the top, but I could make a case either way,

Note that the README has changed considerably, so this PR needs to be updated.

@MathiasMagnus
Copy link
Contributor

@mmha Apologies for having overlooked this contribution, it somehow fell off my stack.

With the "recent" developments around helping users more easily put together a development environment, I think this content would make most sense in the OpenCL-Guide under the CMake Build System Support chapter, specifically the parts detailing package manager support. The current readme already "gently" suggests users to use the OpenCL-SDK to obtain a complete developer package including the C++ headers (and utility libs by default) too. So I think the overarching issue you're trying to remedy here has been triaged. Let us know if you think so too.

FWIW I am a Khronos member (as things stand currently) so in Vcpkg land you do already have a 1st party ally. 😀 One of the first things I wanted to do after we shipped the new batch of native samples and utility libraries for the SDK was hook it all up into Vcpkg, but unfortunately the vcpkg_from_github command can't clone recursively, so I've opened an issue asking for this feature to simplify the Vcpkg portfile. The SDK likely also simplifies things on the Conan end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants